Fix git-latest ansible-lint errors

Reference: https://ansible-lint.readthedocs.io/en/latest/default_rules/#git-latest

Our variable naming is not necessarily consistent across roles.
I've tried to follow the naming conventions of each individual role.
All new variables are suffixed with `_version`, but the prefix may be
somewhat different.

roles/matrix-backup-borg/defaults/main.yml

@@ -8,6 +8,7 @@ matrix_backup_borg_config_path: "{{ matrix_backup_borg_base_path }}/config"
 
 matrix_backup_borg_container_image_self_build: false
 matrix_backup_borg_docker_repo: "https://gitlab.com/etke.cc/borgmatic"
+matrix_backup_borg_docker_repo_version: main
 matrix_backup_borg_docker_src_files_path: "{{ matrix_backup_borg_base_path }}/docker-src"
 
 # version determined automatically, based on postgres server version (if enabled), otherwise latest is used

roles/matrix-backup-borg/tasks/setup_install.yml

@@ -63,6 +63,7 @@
 - name: Ensure borg repository is present on self-build
   ansible.builtin.git:
     repo: "{{ matrix_backup_borg_docker_repo }}"
+    version: "{{ matrix_backup_borg_docker_repo_version }}"
     dest: "{{ matrix_backup_borg_docker_src_files_path }}"
     force: "yes"
   become: true

roles/matrix-bot-buscarron/defaults/main.yml

@@ -6,6 +6,7 @@ matrix_bot_buscarron_enabled: true
 
 matrix_bot_buscarron_container_image_self_build: false
 matrix_bot_buscarron_docker_repo: "https://gitlab.com/etke.cc/buscarron.git"
+matrix_bot_buscarron_docker_repo_version: "{{ matrix_bot_buscarron_version }}"
 matrix_bot_buscarron_docker_src_files_path: "{{ matrix_base_data_path }}/buscarron/docker-src"
 
 matrix_bot_buscarron_version: v1.2.0

roles/matrix-bot-buscarron/tasks/setup_install.yml

@@ -62,6 +62,7 @@
 - name: Ensure buscarron repository is present on self-build
   ansible.builtin.git:
     repo: "{{ matrix_bot_buscarron_docker_repo }}"
+    version: "{{ matrix_bot_buscarron_docker_repo_version }}"
     dest: "{{ matrix_bot_buscarron_docker_src_files_path }}"
     force: "yes"
   become: true

roles/matrix-bot-honoroit/defaults/main.yml

@@ -6,6 +6,7 @@ matrix_bot_honoroit_enabled: true
 
 matrix_bot_honoroit_container_image_self_build: false
 matrix_bot_honoroit_docker_repo: "https://gitlab.com/etke.cc/honoroit.git"
+matrix_bot_honoroit_docker_repo_version: "{{ matrix_bot_honoroit_version }}"
 matrix_bot_honoroit_docker_src_files_path: "{{ matrix_base_data_path }}/honoroit/docker-src"
 
 matrix_bot_honoroit_version: v0.9.9

roles/matrix-bot-honoroit/tasks/setup_install.yml

@@ -62,6 +62,7 @@
 - name: Ensure honoroit repository is present on self-build
   ansible.builtin.git:
     repo: "{{ matrix_bot_honoroit_docker_repo }}"
+    version: "{{ matrix_bot_honoroit_docker_repo_version }}"
     dest: "{{ matrix_bot_honoroit_docker_src_files_path }}"
     force: "yes"
   become: true

roles/matrix-bot-matrix-registration-bot/defaults/main.yml

@@ -5,6 +5,7 @@
 matrix_bot_matrix_registration_bot_enabled: true
 matrix_bot_matrix_registration_bot_container_image_self_build: false
 matrix_bot_matrix_registration_bot_docker_repo: "https://github.com/moan0s/matrix-registration-bot.git"
+matrix_bot_matrix_registration_bot_docker_repo_version: "{{ matrix_bot_matrix_registration_bot_version if matrix_bot_matrix_registration_bot_version != 'latest' else 'main' }}"
 matrix_bot_matrix_registration_bot_docker_src_files_path: "{{ matrix_bot_matrix_registration_bot_base_path }}/docker-src"
 
 matrix_bot_matrix_registration_bot_version: latest

roles/matrix-bot-matrix-registration-bot/tasks/setup_install.yml

@@ -36,6 +36,7 @@
 - name: Ensure matrix-registration-bot repository is present on self-build
   ansible.builtin.git:
     repo: "{{ matrix_bot_matrix_registration_bot_docker_repo }}"
+    version: "{{ matrix_bot_matrix_registration_bot_docker_repo_version }}"
     dest: "{{ matrix_bot_matrix_registration_bot_docker_src_files_path }}"
     force: "yes"
   become: true

roles/matrix-bot-matrix-reminder-bot/defaults/main.yml

@@ -6,6 +6,7 @@ matrix_bot_matrix_reminder_bot_enabled: true
 
 matrix_bot_matrix_reminder_bot_container_image_self_build: false
 matrix_bot_matrix_reminder_bot_docker_repo: "https://github.com/anoadragon453/matrix-reminder-bot.git"
+matrix_bot_matrix_reminder_bot_docker_repo_version: "{{ matrix_bot_matrix_reminder_bot_version }}"
 matrix_bot_matrix_reminder_bot_docker_src_files_path: "{{ matrix_base_data_path }}/matrix-reminder-bot/docker-src"
 
 matrix_bot_matrix_reminder_bot_version: release-v0.2.1

roles/matrix-bot-matrix-reminder-bot/tasks/setup_install.yml

@@ -55,6 +55,7 @@
 - name: Ensure matrix-reminder-bot repository is present on self-build
   ansible.builtin.git:
     repo: "{{ matrix_bot_matrix_reminder_bot_docker_repo }}"
+    version: "{{ matrix_bot_matrix_reminder_bot_docker_repo_version }}"
     dest: "{{ matrix_bot_matrix_reminder_bot_docker_src_files_path }}"
     force: "yes"
   become: true

roles/matrix-bridge-appservice-irc/defaults/main.yml

@@ -6,10 +6,14 @@ matrix_appservice_irc_enabled: true
 
 matrix_appservice_irc_container_image_self_build: false
 matrix_appservice_irc_docker_repo: "https://github.com/matrix-org/matrix-appservice-irc.git"
+matrix_appservice_irc_docker_repo_version: "{{ 'master' if matrix_appservice_irc_version == 'latest' else matrix_appservice_irc_version }}"
 matrix_appservice_irc_docker_src_files_path: "{{ matrix_base_data_path }}/appservice-irc/docker-src"
 
-matrix_appservice_irc_version: release-0.34.0
+# matrix_appservice_irc_version used to contain the full Docker image tag (e.g. `release-X.X.X`).
-matrix_appservice_irc_docker_image: "{{ matrix_container_global_registry_prefix }}matrixdotorg/matrix-appservice-irc:{{ matrix_appservice_irc_version }}"
+# It's a bare version number now. We try to somewhat retain compatibility below.
+matrix_appservice_irc_version: 0.34.0
+matrix_appservice_irc_docker_image: "{{ matrix_container_global_registry_prefix }}matrixdotorg/matrix-appservice-irc:{{ matrix_appservice_irc_docker_image_tag }}"
+matrix_appservice_irc_docker_image_tag: "{{ 'latest' if matrix_appservice_irc_version == 'latest' else ('release-' + matrix_appservice_irc_version) }}"
 matrix_appservice_irc_docker_image_force_pull: "{{ matrix_appservice_irc_docker_image.endswith(':latest') }}"
 
 matrix_appservice_irc_base_path: "{{ matrix_base_data_path }}/appservice-irc"

roles/matrix-bridge-appservice-irc/tasks/setup_install.yml

@@ -72,6 +72,7 @@
 - name: Ensure matrix-appservice-irc repository is present when self-building
   ansible.builtin.git:
     repo: "{{ matrix_appservice_irc_docker_repo }}"
+    version: "{{ matrix_appservice_irc_docker_repo_version }}"
     dest: "{{ matrix_appservice_irc_docker_src_files_path }}"
     force: "yes"
   become: true

roles/matrix-bridge-appservice-slack/defaults/main.yml

@@ -6,10 +6,14 @@ matrix_appservice_slack_enabled: true
 
 matrix_appservice_slack_container_image_self_build: false
 matrix_appservice_slack_docker_repo: "https://github.com/matrix-org/matrix-appservice-slack.git"
+matrix_appservice_slack_docker_repo_version: "{{ 'master' if matrix_appservice_slack_version == 'latest' else matrix_appservice_slack_version }}"
 matrix_appservice_slack_docker_src_files_path: "{{ matrix_base_data_path }}/appservice-slack/docker-src"
 
-matrix_appservice_slack_version: release-1.11.0
+# matrix_appservice_slack_version used to contain the full Docker image tag (e.g. `release-X.X.X`).
-matrix_appservice_slack_docker_image: "{{ matrix_container_global_registry_prefix }}matrixdotorg/matrix-appservice-slack:{{ matrix_appservice_slack_version }}"
+# It's a bare version number now. We try to somewhat retain compatibility below.
+matrix_appservice_slack_version: 1.11.0
+matrix_appservice_slack_docker_image: "{{ matrix_container_global_registry_prefix }}matrixdotorg/matrix-appservice-slack:{{ matrix_appservice_slack_docker_image_tag }}"
+matrix_appservice_slack_docker_image_tag: "{{ 'latest' if matrix_appservice_slack_version == 'latest' else ('release-' + matrix_appservice_slack_version) }}"
 matrix_appservice_slack_docker_image_force_pull: "{{ matrix_appservice_slack_docker_image.endswith(':latest') }}"
 
 matrix_appservice_slack_base_path: "{{ matrix_base_data_path }}/appservice-slack"

roles/matrix-bridge-appservice-slack/tasks/setup_install.yml

@@ -46,6 +46,7 @@
 - name: Ensure matrix-appservice-slack repository is present when self-building
   ansible.builtin.git:
     repo: "{{ matrix_appservice_slack_docker_repo }}"
+    version: "{{ matrix_appservice_slack_docker_repo_version }}"
     dest: "{{ matrix_appservice_slack_docker_src_files_path }}"
     force: "yes"
   become: true

roles/matrix-bridge-mautrix-googlechat/defaults/main.yml

@@ -6,6 +6,7 @@ matrix_mautrix_googlechat_enabled: true
 
 matrix_mautrix_googlechat_container_image_self_build: false
 matrix_mautrix_googlechat_container_image_self_build_repo: "https://github.com/mautrix/googlechat.git"
+matrix_mautrix_googlechat_container_image_self_build_repo_version: "{{ 'master' if matrix_mautrix_googlechat_version == 'latest' else matrix_mautrix_googlechat_version }}"
 
 matrix_mautrix_googlechat_version: v0.3.3
 # See: https://mau.dev/mautrix/googlechat/container_registry

roles/matrix-bridge-mautrix-googlechat/tasks/setup_install.yml

@@ -63,6 +63,7 @@
 - name: Ensure Mautrix Hangots repository is present on self build
   ansible.builtin.git:
     repo: "{{ matrix_mautrix_googlechat_container_image_self_build_repo }}"
+    version: "{{ matrix_mautrix_googlechat_container_image_self_build_repo_version }}"
     dest: "{{ matrix_mautrix_googlechat_docker_src_files_path }}"
     force: "yes"
   become: true

roles/matrix-bridge-mautrix-hangouts/defaults/main.yml

@@ -6,6 +6,7 @@ matrix_mautrix_hangouts_enabled: true
 
 matrix_mautrix_hangouts_container_image_self_build: false
 matrix_mautrix_hangouts_container_image_self_build_repo: "https://github.com/mautrix/hangouts.git"
+matrix_mautrix_hangouts_container_image_self_build_repo_version: "{{ 'master' if matrix_mautrix_hangouts_version == 'latest' else matrix_mautrix_googlechat_version }}"
 
 matrix_mautrix_hangouts_version: latest
 # See: https://mau.dev/mautrix/hangouts/container_registry

roles/matrix-bridge-mautrix-hangouts/tasks/setup_install.yml

@@ -63,6 +63,7 @@
 - name: Ensure Mautrix Hangots repository is present on self build
   ansible.builtin.git:
     repo: "{{ matrix_mautrix_hangouts_container_image_self_build_repo }}"
+    version: "{{ matrix_mautrix_hangouts_container_image_self_build_repo_version }}"
     dest: "{{ matrix_mautrix_hangouts_docker_src_files_path }}"
     force: "yes"
   become: true

roles/matrix-bridge-mautrix-instagram/defaults/main.yml

@@ -6,6 +6,7 @@ matrix_mautrix_instagram_enabled: true
 
 matrix_mautrix_instagram_container_image_self_build: false
 matrix_mautrix_instagram_container_image_self_build_repo: "https://github.com/mautrix/instagram.git"
+matrix_mautrix_instagram_container_image_self_build_repo_version: "{{ 'master' if matrix_mautrix_instagram_version == 'latest' else matrix_mautrix_instagram_version }}"
 
 matrix_mautrix_instagram_version: v0.1.3
 # See: https://mau.dev/tulir/mautrix-instagram/container_registry

roles/matrix-bridge-mautrix-instagram/tasks/setup_install.yml

@@ -36,6 +36,7 @@
 - name: Ensure Mautrix instagram repository is present on self-build
   ansible.builtin.git:
     repo: "{{ matrix_mautrix_instagram_container_image_self_build_repo }}"
+    version: "{{ matrix_mautrix_instagram_container_image_self_build_repo_version }}"
     dest: "{{ matrix_mautrix_instagram_docker_src_files_path }}"
     force: "yes"
   become: true

roles/matrix-bridge-mautrix-signal/defaults/main.yml

@@ -6,6 +6,7 @@ matrix_mautrix_signal_enabled: true
 
 matrix_mautrix_signal_container_image_self_build: false
 matrix_mautrix_signal_docker_repo: "https://mau.dev/mautrix/signal.git"
+matrix_mautrix_signal_docker_repo_version: "{{ 'master' if matrix_mautrix_signal_version == 'latest' else matrix_mautrix_signal_version }}"
 matrix_mautrix_signal_docker_src_files_path: "{{ matrix_base_data_path }}/mautrix-signal/docker-src"
 
 matrix_mautrix_signal_version: v0.3.0
@@ -16,6 +17,7 @@ matrix_mautrix_signal_docker_image_force_pull: "{{ matrix_mautrix_signal_docker_
 
 matrix_mautrix_signal_daemon_container_image_self_build: false
 matrix_mautrix_signal_daemon_docker_repo: "https://gitlab.com/signald/signald"
+matrix_mautrix_signal_daemon_docker_repo_version: "{{ 'master' if matrix_mautrix_signal_daemon_version == 'latest' else matrix_mautrix_signal_daemon_version }}"
 matrix_mautrix_signal_daemon_docker_src_files_path: "{{ matrix_base_data_path }}/mautrix-signald/docker-src"
 
 matrix_mautrix_signal_daemon_docker_image: "docker.io/signald/signald:{{ matrix_mautrix_signal_daemon_docker_image_tag }}"

roles/matrix-bridge-mautrix-signal/tasks/setup_install.yml

@@ -24,6 +24,7 @@
 - name: Ensure Mautrix Signal repository is present on self-build
   ansible.builtin.git:
     repo: "{{ matrix_mautrix_signal_docker_repo }}"
+    version: "{{ matrix_mautrix_signal_docker_repo_version }}"
     dest: "{{ matrix_mautrix_signal_docker_src_files_path }}"
     force: "yes"
   become: true
@@ -56,6 +57,7 @@
 - name: Ensure Mautrix Signal Daemon repository is present on self-build
   ansible.builtin.git:
     repo: "{{ matrix_mautrix_signal_daemon_docker_repo }}"
+    version: "{{ matrix_mautrix_signal_daemon_docker_repo_version }}"
     dest: "{{ matrix_mautrix_signal_daemon_docker_src_files_path }}"
     force: "yes"
   become: true

roles/matrix-bridge-mautrix-telegram/defaults/main.yml

@@ -7,11 +7,13 @@ matrix_mautrix_telegram_enabled: true
 matrix_telegram_lottieconverter_container_image_self_build: false
 matrix_telegram_lottieconverter_container_image_self_build_mask_arch: false
 matrix_telegram_lottieconverter_docker_repo: "https://mau.dev/tulir/lottieconverter.git"
+matrix_telegram_lottieconverter_docker_repo_version: "master"
 matrix_telegram_lottieconverter_docker_src_files_path: "{{ matrix_base_data_path }}/lotticonverter/docker-src"
 matrix_telegram_lottieconverter_docker_image: "dock.mau.dev/tulir/lottieconverter:alpine-3.15"  # needs to be ajusted according to FROM clause of Dockerfile of mautrix-telegram
 
 matrix_mautrix_telegram_container_image_self_build: false
 matrix_mautrix_telegram_docker_repo: "https://mau.dev/mautrix/telegram.git"
+matrix_mautrix_telegram_docker_repo_version: "{{ 'master' if matrix_mautrix_telegram_version == 'latest' else matrix_mautrix_telegram_version }}"
 matrix_mautrix_telegram_docker_src_files_path: "{{ matrix_base_data_path }}/mautrix-telegram/docker-src"
 
 matrix_mautrix_telegram_version: v0.11.3

roles/matrix-bridge-mautrix-telegram/tasks/setup_install.yml

@@ -63,6 +63,7 @@
 - name: Ensure lottieconverter is present when self-building
   ansible.builtin.git:
     repo: "{{ matrix_telegram_lottieconverter_docker_repo }}"
+    version: "{{ matrix_telegram_lottieconverter_docker_repo_version }}"
     dest: "{{ matrix_telegram_lottieconverter_docker_src_files_path }}"
     force: "yes"
   become: true
@@ -85,6 +86,7 @@
 - name: Ensure matrix-mautrix-telegram repository is present when self-building
   ansible.builtin.git:
     repo: "{{ matrix_mautrix_telegram_docker_repo }}"
+    version: "{{ matrix_mautrix_telegram_docker_repo_version }}"
     dest: "{{ matrix_mautrix_telegram_docker_src_files_path }}"
     force: "yes"
   become: true

roles/matrix-bridge-mautrix-twitter/defaults/main.yml

@@ -6,6 +6,7 @@ matrix_mautrix_twitter_enabled: true
 
 matrix_mautrix_twitter_container_image_self_build: false
 matrix_mautrix_twitter_container_image_self_build_repo: "https://github.com/mautrix/twitter.git"
+matrix_mautrix_twitter_container_image_self_build_repo_version: "{{ 'master' if matrix_mautrix_twitter_version == 'latest' else matrix_mautrix_twitter_version }}"
 
 matrix_mautrix_twitter_version: v0.1.4
 # See: https://mau.dev/tulir/mautrix-twitter/container_registry

roles/matrix-bridge-mautrix-twitter/tasks/setup_install.yml

@@ -40,8 +40,8 @@
 - name: Ensure Mautrix Twitter repository is present on self-build
   ansible.builtin.git:
     repo: "{{ matrix_mautrix_twitter_container_image_self_build_repo }}"
+    version: "{{ matrix_mautrix_twitter_container_image_self_build_repo_version }}"
     dest: "{{ matrix_mautrix_twitter_docker_src_files_path }}"
-    # version: "{{ matrix_coturn_docker_image.split(':')[1] }}"
     force: "yes"
   become: true
   become_user: "{{ matrix_user_username }}"

roles/matrix-bridge-mx-puppet-groupme/defaults/main.yml

@@ -6,6 +6,7 @@ matrix_mx_puppet_groupme_enabled: true
 
 matrix_mx_puppet_groupme_container_image_self_build: false
 matrix_mx_puppet_groupme_container_image_self_build_repo: "https://gitlab.com/robintown/mx-puppet-groupme"
+matrix_mx_puppet_groupme_container_image_self_build_repo_version: "{{ 'main' if matrix_mx_puppet_groupme_version == 'latest' else matrix_mx_puppet_groupme_version }}"
 
 # Controls whether the mx-puppet-groupme container exposes its HTTP port (tcp/8437 in the container).
 #

roles/matrix-bridge-mx-puppet-groupme/tasks/setup_install.yml

@@ -81,6 +81,7 @@
 - name: Ensure MX Puppet Groupme repository is present on self build
   ansible.builtin.git:
     repo: "{{ matrix_mx_puppet_groupme_container_image_self_build_repo }}"
+    version: "{{ matrix_mx_puppet_groupme_container_image_self_build_repo_version }}"
     dest: "{{ matrix_mx_puppet_groupme_docker_src_files_path }}"
     force: "yes"
   become: true

roles/matrix-bridge-mx-puppet-instagram/defaults/main.yml

@@ -6,6 +6,7 @@ matrix_mx_puppet_instagram_enabled: true
 
 matrix_mx_puppet_instagram_container_image_self_build: false
 matrix_mx_puppet_instagram_container_image_self_build_repo: "https://github.com/Sorunome/mx-puppet-instagram.git"
+matrix_mx_puppet_instagram_container_image_self_build_repo_version: "{{ 'master' if matrix_mx_puppet_instagram_version == 'latest' else matrix_mx_puppet_instagram_version }}"
 
 matrix_mx_puppet_instagram_version: latest
 matrix_mx_puppet_instagram_docker_image: "{{ matrix_mx_puppet_instagram_docker_image_name_prefix }}sorunome/mx-puppet-instagram:{{ matrix_mx_puppet_instagram_version }}"

roles/matrix-bridge-mx-puppet-instagram/tasks/setup_install.yml

@@ -64,6 +64,7 @@
 - name: Ensure mx-puppet-instagram repository is present on self build
   ansible.builtin.git:
     repo: "{{ matrix_mx_puppet_instagram_container_image_self_build_repo }}"
+    version: "{{ matrix_mx_puppet_instagram_container_image_self_build_repo_version }}"
     dest: "{{ matrix_mx_puppet_instagram_docker_src_files_path }}"
     force: "yes"
   become: true

roles/matrix-bridge-mx-puppet-steam/defaults/main.yml

@@ -6,6 +6,7 @@ matrix_mx_puppet_steam_enabled: true
 
 matrix_mx_puppet_steam_container_image_self_build: false
 matrix_mx_puppet_steam_container_image_self_build_repo: "https://github.com/icewind1991/mx-puppet-steam.git"
+matrix_mx_puppet_steam_container_image_self_build_repo_version: "{{ 'master' if matrix_mx_puppet_steam_version == 'latest' else matrix_mx_puppet_steam_version }}"
 
 # Controls whether the mx-puppet-steam container exposes its HTTP port (tcp/8432 in the container).
 #

roles/matrix-bridge-mx-puppet-steam/tasks/setup_install.yml

@@ -81,6 +81,7 @@
 - name: Ensure MX Puppet Steam repository is present on self build
   ansible.builtin.git:
     repo: "{{ matrix_mx_puppet_steam_container_image_self_build_repo }}"
+    version: "{{ matrix_mx_puppet_steam_container_image_self_build_repo_version }}"
     dest: "{{ matrix_mx_puppet_steam_docker_src_files_path }}"
     force: "yes"
   become: true

roles/matrix-client-element/defaults/main.yml

@@ -89,6 +89,7 @@ matrix_client_element_enable_presence_by_hs_url: ~
 # will be installed and enabled automatically.
 matrix_client_element_themes_enabled: false
 matrix_client_element_themes_repository_url: https://github.com/aaronraimist/element-themes
+matrix_client_element_themes_repository_version: master
 
 # Controls the default theme
 matrix_client_element_default_theme: 'light'

roles/matrix-client-element/tasks/prepare_themes.yml

@@ -8,6 +8,7 @@
   - name: Ensure Element themes repository is pulled
     ansible.builtin.git:
       repo: "{{ matrix_client_element_themes_repository_url }}"
+      version: "{{ matrix_client_element_themes_repository_version }}"
       dest: "{{ role_path }}/files/scratchpad/themes"
 
   - name: Find all Element theme files