Add conditional restart support to client, bot, and bridge roles

For each of the 34 roles (3 clients, 9 bots, 22 bridges), this commit:
- Adds `_restart_necessary: false` default variable
- Adds `register:` directives to config/image/systemd tasks
- Computes `_restart_necessary` via set_fact (OR of all .changed results)
- Wires `(_restart_necessary | bool)` in group_vars/matrix_servers

This allows the systemd service manager to skip unnecessary restarts
when running install-* tags and nothing actually changed.

Service roles and complex multi-service roles will follow separately.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Slavi Pantaleev
2026-02-13 15:33:54 +02:00
parent 6da1223500
commit 16010ff8c7
69 changed files with 920 additions and 102 deletions

View File

@@ -136,3 +136,13 @@ matrix_mx_puppet_groupme_registration_yaml: |
receive_ephemeral: true
matrix_mx_puppet_groupme_registration: "{{ matrix_mx_puppet_groupme_registration_yaml | from_yaml }}"
# matrix_mx_puppet_groupme_restart_necessary controls whether the service
# will be restarted (when true) or merely started (when false) by the
# systemd service manager role (when conditional restart is enabled).
#
# This value is automatically computed during installation based on whether
# any configuration files, the systemd service file, or the container image changed.
# The default of `false` means "no restart needed" — appropriate when the role's
# installation tasks haven't run (e.g., due to --tags skipping them).
matrix_mx_puppet_groupme_restart_necessary: false

View File

@@ -79,10 +79,10 @@
force_source: "{{ matrix_mx_puppet_groupme_docker_image_force_pull if ansible_version.major > 2 or ansible_version.minor >= 8 else omit }}"
force: "{{ omit if ansible_version.major > 2 or ansible_version.minor >= 8 else matrix_mx_puppet_groupme_docker_image_force_pull }}"
when: matrix_mx_puppet_groupme_enabled | bool and not matrix_mx_puppet_groupme_container_image_self_build
register: result
register: matrix_mx_puppet_groupme_container_image_pull_result
retries: "{{ devture_playbook_help_container_retries_count }}"
delay: "{{ devture_playbook_help_container_retries_delay }}"
until: result is not failed
until: matrix_mx_puppet_groupme_container_image_pull_result is not failed
- name: Ensure MX Puppet Groupme repository is present on self build
ansible.builtin.git:
@@ -114,6 +114,7 @@
mode: 0644
owner: "{{ matrix_user_name }}"
group: "{{ matrix_group_name }}"
register: matrix_mx_puppet_groupme_config_result
- name: Ensure mx-puppet-groupme groupme-registration.yaml installed
ansible.builtin.copy:
@@ -122,6 +123,7 @@
mode: 0644
owner: "{{ matrix_user_name }}"
group: "{{ matrix_group_name }}"
register: matrix_mx_puppet_groupme_registration_result
- name: Ensure mx-puppet-groupme container network is created
community.general.docker_network:
@@ -135,6 +137,18 @@
src: "{{ role_path }}/templates/systemd/matrix-mx-puppet-groupme.service.j2"
dest: "/etc/systemd/system/matrix-mx-puppet-groupme.service"
mode: 0644
register: matrix_mx_puppet_groupme_systemd_service_result
- name: Determine whether matrix-mx-puppet-groupme needs a restart
ansible.builtin.set_fact:
matrix_mx_puppet_groupme_restart_necessary: >-
{{
matrix_mx_puppet_groupme_migration_requires_restart | default(false)
or matrix_mx_puppet_groupme_config_result.changed | default(false)
or matrix_mx_puppet_groupme_registration_result.changed | default(false)
or matrix_mx_puppet_groupme_systemd_service_result.changed | default(false)
or matrix_mx_puppet_groupme_container_image_pull_result.changed | default(false)
}}
- name: Ensure matrix-mx-puppet-groupme.service restarted, if necessary
ansible.builtin.service: