Use yaml syntax instead of key=value syntax consistently

fixes #62

roles/matrix-server/tasks/setup/setup_base.yml

@@ -68,11 +68,17 @@
   when: ansible_os_family == 'Debian'
 
 - name: Ensure firewalld is started and autoruns
-  service: name=firewalld state=started enabled=yes
+  service:
+    name: firewalld
+    state: started
+    enabled: yes
   when: ansible_os_family == 'RedHat'
 
 - name: Ensure Docker is started and autoruns
-  service: name=docker state=started enabled=yes
+  service:
+    name: docker 
+    state: started
+    enabled: yes
 
 - name: Ensure ntpd is started and autoruns
   service:

roles/matrix-server/tasks/setup/setup_goofys.yml

@@ -9,7 +9,8 @@
 
 # This will throw a Permission Denied error if already mounted
 - name: Check Matrix Goofys external storage mountpoint path
-  stat: path="{{ matrix_synapse_media_store_path }}"
+  stat:
+    path: "{{ matrix_synapse_media_store_path }}"
   register: local_path_matrix_synapse_media_store_path_stat
   ignore_errors: yes
   when: matrix_s3_media_store_enabled
@@ -43,11 +44,15 @@
 #
 
 - name: Check existence of matrix-goofys service
-  stat: path="/etc/systemd/system/matrix-goofys.service"
+  stat:
+    path: "/etc/systemd/system/matrix-goofys.service"
   register: matrix_goofys_service_stat
 
 - name: Ensure matrix-goofys is stopped
-  service: name=matrix-goofys state=stopped daemon_reload=yes
+  service:
+    name: matrix-goofys
+    state: stopped
+    daemon_reload: yes
   register: stopping_result
   when: "not matrix_s3_media_store_enabled and matrix_goofys_service_stat.stat.exists"
 

roles/matrix-server/tasks/setup/setup_mailer.yml

@@ -29,11 +29,15 @@
 #
 
 - name: Check existence of matrix-mailer service
-  stat: path="/etc/systemd/system/matrix-mailer.service"
+  stat:
+    path: "/etc/systemd/system/matrix-mailer.service"
   register: matrix_mailer_service_stat
 
 - name: Ensure matrix-mailer is stopped
-  service: name=matrix-mailer state=stopped daemon_reload=yes
+  service:
+    name: matrix-mailer
+    state: stopped
+    daemon_reload: yes
   register: stopping_result
   when: "not matrix_mailer_enabled and matrix_mailer_service_stat.stat.exists"
 
@@ -53,4 +57,4 @@
   docker_image:
     name: "{{ matrix_mailer_docker_image }}"
     state: absent
-  when: "not matrix_mailer_enabled"
+  when: "not matrix_mailer_enabled"

roles/matrix-server/tasks/setup/setup_mxisd.yml

@@ -52,11 +52,15 @@
 #
 
 - name: Check existence of matrix-mxisd service
-  stat: path="/etc/systemd/system/matrix-mxisd.service"
+  stat:
+    path: "/etc/systemd/system/matrix-mxisd.service"
   register: matrix_mxisd_service_stat
 
 - name: Ensure matrix-mxisd is stopped
-  service: name=matrix-mxisd state=stopped daemon_reload=yes
+  service:
+    name: matrix-mxisd
+    state: stopped 
+    daemon_reload: yes
   register: stopping_result
   when: "not matrix_mxisd_enabled and matrix_mxisd_service_stat.stat.exists"
 
@@ -76,4 +80,4 @@
   docker_image:
     name: "{{ matrix_mxisd_docker_image }}"
     state: absent
-  when: "not matrix_mxisd_enabled"
+  when: "not matrix_mxisd_enabled"

roles/matrix-server/tasks/setup/setup_nginx_proxy.yml

@@ -69,11 +69,15 @@
 #
 
 - name: Check existence of matrix-nginx-proxy service
-  stat: path="/etc/systemd/system/matrix-nginx-proxy.service"
+  stat:
+    path: "/etc/systemd/system/matrix-nginx-proxy.service"
   register: matrix_nginx_proxy_service_stat
 
 - name: Ensure matrix-nginx-proxy is stopped
-  service: name=matrix-nginx-proxy state=stopped daemon_reload=yes
+  service:
+    name: matrix-nginx-proxy
+    state: stopped
+    daemon_reload: yes
   register: stopping_result
   when: "not matrix_nginx_proxy_enabled and matrix_nginx_proxy_service_stat.stat.exists"
 

roles/matrix-server/tasks/setup/setup_postgres.yml

@@ -69,12 +69,16 @@
 #
 
 - name: Check existence of matrix-postgres service
-  stat: path="/etc/systemd/system/matrix-postgres.service"
+  stat:
+    path: "/etc/systemd/system/matrix-postgres.service"
   register: matrix_postgres_service_stat
   when: matrix_postgres_use_external
 
 - name: Ensure matrix-postgres is stopped
-  service: name=matrix-postgres state=stopped daemon_reload=yes
+  service:
+    name: matrix-postgres
+    state: stopped
+    daemon_reload: yes
   when: "matrix_postgres_use_external and matrix_postgres_service_stat.stat.exists"
 
 - name: Ensure matrix-postgres.service doesn't exist
@@ -84,7 +88,8 @@
   when: "matrix_postgres_use_external and matrix_postgres_service_stat.stat.exists"
 
 - name: Check existence of matrix-postgres local data path
-  stat: path="{{ matrix_postgres_data_path }}"
+  stat:
+    path: "{{ matrix_postgres_data_path }}"
   register: matrix_postgres_data_path_stat
   when: matrix_postgres_use_external
 

roles/matrix-server/tasks/setup/setup_riot_web.yml

@@ -43,11 +43,15 @@
 #
 
 - name: Check existence of matrix-riot-web service
-  stat: path="/etc/systemd/system/matrix-riot-web.service"
+  stat:
+    path: "/etc/systemd/system/matrix-riot-web.service"
   register: matrix_riot_web_service_stat
 
 - name: Ensure matrix-riot-web is stopped
-  service: name=matrix-riot-web state=stopped daemon_reload=yes
+  service:
+    name: matrix-riot-web
+    state: stopped
+    daemon_reload: yes
   register: stopping_result
   when: "not matrix_riot_web_enabled and matrix_riot_web_service_stat.stat.exists"
 

roles/matrix-server/tasks/setup/synapse/ext/setup_synapse_ext_mautrix_telegram.yml

@@ -33,7 +33,8 @@
     mode: 0644
   when: "matrix_mautrix_telegram_enabled"
 
-- stat: "path={{ matrix_mautrix_telegram_base_path }}/registration.yaml"
+- stat:
+    path: "{{ matrix_mautrix_telegram_base_path }}/registration.yaml"
   register: mautrix_telegram_registration_file
 
 - name: Generate matrix-mautrix-telegram registration.yaml if it doesn't exist

roles/matrix-server/tasks/setup/synapse/ext/setup_synapse_ext_mautrix_whatsapp.yml

@@ -33,7 +33,8 @@
     mode: 0644
   when: "matrix_mautrix_whatsapp_enabled"
 
-- stat: "path={{ matrix_mautrix_whatsapp_base_path }}/registration.yaml"
+- stat:
+    path: "{{ matrix_mautrix_whatsapp_base_path }}/registration.yaml"
   register: mautrix_whatsapp_registration_file
 
 - name: Generate matrix-mautrix-whatsapp registration.yaml if it doesn't exist

roles/matrix-server/tasks/setup/synapse/setup_synapse_main.yml

@@ -2,7 +2,8 @@
 
 # This will throw a Permission Denied error if already mounted using fuse
 - name: Check Matrix Synapse media store path
-  stat: path="{{ matrix_synapse_media_store_path }}"
+  stat:
+    path: "{{ matrix_synapse_media_store_path }}"
   register: local_path_media_store_stat
   ignore_errors: yes