Update slack bridge implementation

roles/custom/matrix-bridge-mautrix-slack/tasks/init.yml

@@ -1,21 +0,0 @@
----
-- ansible.builtin.set_fact:
-    matrix_systemd_services_list: "{{ matrix_systemd_services_list + ['matrix-mautrix-slack.service'] }}"
-  when: matrix_mautrix_slack_enabled | bool
-
-# If the matrix-synapse role is not used, these variables may not exist.
-- ansible.builtin.set_fact:
-    matrix_homeserver_container_runtime_injected_arguments: >
-      {{
-        matrix_homeserver_container_runtime_injected_arguments | default([])
-        +
-        ["--mount type=bind,src={{ matrix_mautrix_slack_config_path }}/registration.yaml,dst=/matrix-mautrix-slack-registration.yaml,ro"]
-      }}
-
-    matrix_homeserver_app_service_runtime_injected_config_files: >
-      {{
-        matrix_homeserver_app_service_runtime_injected_config_files | default([])
-        +
-        ["/matrix-mautrix-slack-registration.yaml"]
-      }}
-  when: matrix_mautrix_slack_enabled | bool

roles/custom/matrix-bridge-mautrix-slack/tasks/main.yml

@@ -1,22 +1,20 @@
 ---
-- ansible.builtin.import_tasks: "{{ role_path }}/tasks/init.yml"
-  tags:
-    - always
 
-- ansible.builtin.import_tasks: "{{ role_path }}/tasks/validate_config.yml"
-  when: "run_setup | bool and matrix_mautrix_slack_enabled | bool"
+- block:
+    - when: matrix_mautrix_slack_enabled | bool
+      ansible.builtin.include_tasks: "{{ role_path }}/tasks/validate_config.yml"
+
+    - when: matrix_mautrix_slack_enabled | bool
+      ansible.builtin.include_tasks: "{{ role_path }}/tasks/setup_install.yml"
   tags:
     - setup-all
     - setup-mautrix-slack
+    - install-all
+    - install-mautrix-slack
 
-- ansible.builtin.import_tasks: "{{ role_path }}/tasks/setup_install.yml"
-  when: "run_setup and matrix_mautrix_slack_enabled"
-  tags:
-    - setup-all
-    - setup-mautrix-slack
-
-- ansible.builtin.import_tasks: "{{ role_path }}/tasks/setup_uninstall.yml"
-  when: "run_setup and not matrix_mautrix_slack_enabled"
+- block:
+    - when: not matrix_mautrix_slack_enabled | bool
+      ansible.builtin.include_tasks: "{{ role_path }}/tasks/setup_uninstall.yml"
   tags:
     - setup-all
     - setup-mautrix-slack

roles/custom/matrix-bridge-mautrix-slack/tasks/setup_install.yml

@@ -1,13 +1,5 @@
 ---
 
-# If the matrix-synapse role is not used, `matrix_synapse_role_executed` won't exist.
-# We don't want to fail in such cases.
-- name: Fail if matrix-synapse role already executed
-  ansible.builtin.fail:
-    msg: >-
-      The matrix-bridge-mautrix-slack role needs to execute before the matrix-synapse role.
-  when: "matrix_synapse_role_executed | default(False)"
-
 - ansible.builtin.set_fact:
     matrix_mautrix_slack_requires_restart: false
 
@@ -20,8 +12,11 @@
 
     - when: "matrix_mautrix_slack_sqlite_database_path_local_stat_result.stat.exists | bool"
       block:
-        - ansible.builtin.set_fact:
-            matrix_postgres_db_migration_request:
+        - ansible.builtin.include_role:
+            name: galaxy/com.devture.ansible.role.postgres
+            tasks_from: migrate_db_to_postgres
+          vars:
+            devture_postgres_db_migration_request:
               src: "{{ matrix_mautrix_slack_sqlite_database_path_local }}"
               dst: "{{ matrix_mautrix_slack_database_connection_string }}"
               caller: "{{ role_path | basename }}"
@@ -30,10 +25,6 @@
               systemd_services_to_stop: ['matrix-mautrix-slack.service']
               pgloader_options: ['--with "quote identifiers"']
 
-        - ansible.builtin.import_role:
-            name: custom/matrix-postgres
-            tasks_from: migrate_db_to_postgres
-
         - ansible.builtin.set_fact:
             matrix_mautrix_slack_requires_restart: true
 
@@ -109,13 +100,9 @@
     mode: 0644
   register: matrix_mautrix_slack_systemd_service_result
 
-- name: Ensure systemd reloaded after matrix-mautrix-slack.service installation
-  ansible.builtin.service:
-    daemon_reload: true
-  when: "matrix_mautrix_slack_systemd_service_result.changed"
-
 - name: Ensure matrix-mautrix-slack.service restarted, if necessary
   ansible.builtin.service:
     name: "matrix-mautrix-slack.service"
     state: restarted
+    daemon_reload: true
   when: "matrix_mautrix_slack_requires_restart | bool"

roles/custom/matrix-bridge-mautrix-slack/tasks/setup_uninstall.yml

@@ -5,21 +5,16 @@
     path: "{{ devture_systemd_docker_base_systemd_path }}/matrix-mautrix-slack.service"
   register: matrix_mautrix_slack_service_stat
 
-- name: Ensure matrix-mautrix-slack is stopped
-  ansible.builtin.service:
-    name: matrix-mautrix-slack
-    state: stopped
-    enabled: false
-    daemon_reload: true
-  when: "matrix_mautrix_slack_service_stat.stat.exists"
+- when: matrix_mautrix_slack_service_stat.stat.exists | bool
+  block:
+    - name: Ensure matrix-mautrix-slack is stopped
+      ansible.builtin.service:
+        name: matrix-mautrix-slack
+        state: stopped
+        enabled: false
+        daemon_reload: true
 
-- name: Ensure matrix-mautrix-slack.service doesn't exist
-  ansible.builtin.file:
-    path: "{{ devture_systemd_docker_base_systemd_path }}/matrix-mautrix-slack.service"
-    state: absent
-  when: "matrix_mautrix_slack_service_stat.stat.exists"
-
-- name: Ensure systemd reloaded after matrix-mautrix-slack.service removal
-  ansible.builtin.service:
-    daemon_reload: true
-  when: "matrix_mautrix_slack_service_stat.stat.exists"
+    - name: Ensure matrix-mautrix-slack.service doesn't exist
+      ansible.builtin.file:
+        path: "{{ devture_systemd_docker_base_systemd_path }}/matrix-mautrix-slack.service"
+        state: absent