Use fully-qualified module names for builtin Ansible modules

Related to https://github.com/spantaleev/matrix-docker-ansible-deploy/pull/1939

roles/matrix-bridge-mautrix-signal/tasks/init.yml

@@ -1,11 +1,11 @@
 ---
 
-- set_fact:
+- ansible.builtin.set_fact:
     matrix_systemd_services_list: "{{ matrix_systemd_services_list + ['matrix-mautrix-signal.service', 'matrix-mautrix-signal-daemon.service'] }}"
   when: matrix_mautrix_signal_enabled|bool
 
 # If the matrix-synapse role is not used, these variables may not exist.
-- set_fact:
+- ansible.builtin.set_fact:
     matrix_synapse_container_extra_arguments: >
       {{
         matrix_synapse_container_extra_arguments|default([])

roles/matrix-bridge-mautrix-signal/tasks/setup_install.yml

@@ -3,7 +3,7 @@
 # If the matrix-synapse role is not used, `matrix_synapse_role_executed` won't exist.
 # We don't want to fail in such cases.
 - name: Fail if matrix-synapse role already executed
-  fail:
+  ansible.builtin.fail:
     msg: >-
       The matrix-bridge-mautrix-signal role needs to execute before the matrix-synapse role.
   when: "matrix_synapse_role_executed|default(False)"
@@ -22,7 +22,7 @@
 
 
 - name: Ensure Mautrix Signal repository is present on self-build
-  git:
+  ansible.builtin.git:
     repo: "{{ matrix_mautrix_signal_docker_repo }}"
     dest: "{{ matrix_mautrix_signal_docker_src_files_path }}"
     force: "yes"
@@ -54,7 +54,7 @@
   register: matrix_mautrix_signal_daemon_pull_results
 
 - name: Ensure Mautrix Signal Daemon repository is present on self-build
-  git:
+  ansible.builtin.git:
     repo: "{{ matrix_mautrix_signal_daemon_docker_repo }}"
     dest: "{{ matrix_mautrix_signal_daemon_docker_src_files_path }}"
     force: "yes"
@@ -76,7 +76,7 @@
   when: "matrix_mautrix_signal_daemon_container_image_self_build|bool"
 
 - name: Ensure Mautrix Signal paths exist
-  file:
+  ansible.builtin.file:
     path: "{{ item }}"
     state: directory
     mode: 0750
@@ -91,7 +91,7 @@
     - "{{ matrix_mautrix_signal_daemon_path }}/data"
 
 - name: Ensure mautrix-signal config.yaml installed
-  copy:
+  ansible.builtin.copy:
     content: "{{ matrix_mautrix_signal_configuration|to_nice_yaml(indent=2, width=999999) }}"
     dest: "{{ matrix_mautrix_signal_config_path }}/config.yaml"
     mode: 0644
@@ -99,7 +99,7 @@
     group: "{{ matrix_user_groupname }}"
 
 - name: Ensure mautrix-signal registration.yaml installed
-  copy:
+  ansible.builtin.copy:
     content: "{{ matrix_mautrix_signal_registration|to_nice_yaml(indent=2, width=999999) }}"
     dest: "{{ matrix_mautrix_signal_config_path }}/registration.yaml"
     mode: 0644
@@ -107,20 +107,20 @@
     group: "{{ matrix_user_groupname }}"
 
 - name: Ensure matrix-mautrix-signal-daemon.service installed
-  template:
+  ansible.builtin.template:
     src: "{{ role_path }}/templates/systemd/matrix-mautrix-signal-daemon.service.j2"
     dest: "{{ matrix_systemd_path }}/matrix-mautrix-signal-daemon.service"
     mode: 0644
   register: matrix_mautrix_signal_daemon_systemd_service_result
 
 - name: Ensure matrix-mautrix-signal.service installed
-  template:
+  ansible.builtin.template:
     src: "{{ role_path }}/templates/systemd/matrix-mautrix-signal.service.j2"
     dest: "{{ matrix_systemd_path }}/matrix-mautrix-signal.service"
     mode: 0644
   register: matrix_mautrix_signal_systemd_service_result
 
 - name: Ensure systemd reloaded after matrix-mautrix-signal.service installation
-  service:
+  ansible.builtin.service:
     daemon_reload: true
   when: "matrix_mautrix_signal_systemd_service_result.changed or matrix_mautrix_signal_daemon_systemd_service_result.changed"

roles/matrix-bridge-mautrix-signal/tasks/setup_uninstall.yml

@@ -7,7 +7,7 @@
   register: matrix_mautrix_signal_daemon_service_stat
 
 - name: Ensure matrix-mautrix-signal-daemon is stopped
-  service:
+  ansible.builtin.service:
     name: matrix-mautrix-signal-daemon
     state: stopped
     enabled: false
@@ -15,7 +15,7 @@
   when: "matrix_mautrix_signal_daemon_service_stat.stat.exists"
 
 - name: Ensure matrix-mautrix-signal-daemon.service doesn't exist
-  file:
+  ansible.builtin.file:
     path: "{{ matrix_systemd_path }}/matrix-mautrix-signal-daemon.service"
     state: absent
   when: "matrix_mautrix_signal_daemon_service_stat.stat.exists"
@@ -27,7 +27,7 @@
   register: matrix_mautrix_signal_service_stat
 
 - name: Ensure matrix-mautrix-signal is stopped
-  service:
+  ansible.builtin.service:
     name: matrix-mautrix-signal
     state: stopped
     enabled: false
@@ -35,13 +35,13 @@
   when: "matrix_mautrix_signal_service_stat.stat.exists"
 
 - name: Ensure matrix-mautrix-signal.service doesn't exist
-  file:
+  ansible.builtin.file:
     path: "{{ matrix_systemd_path }}/matrix-mautrix-signal.service"
     state: absent
   when: "matrix_mautrix_signal_service_stat.stat.exists"
 
 # All services
 - name: Ensure systemd reloaded after matrix-mautrix-signal_X.service removal
-  service:
+  ansible.builtin.service:
     daemon_reload: true
   when: "matrix_mautrix_signal_service_stat.stat.exists or matrix_mautrix_signal_daemon_service_stat.stat.exists"

roles/matrix-bridge-mautrix-signal/tasks/validate_config.yml

@@ -1,7 +1,7 @@
 ---
 
 - name: Fail if required settings not defined
-  fail:
+  ansible.builtin.fail:
     msg: >-
       You need to define a required configuration setting (`{{ item }}`).
   when: "vars[item] == ''"
@@ -12,7 +12,7 @@
     - "matrix_mautrix_signal_appservice_token"
 
 - name: (Deprecation) Catch and report renamed Signal variables
-  fail:
+  ansible.builtin.fail:
     msg: >-
       Your configuration contains a variable, which now has a different name.
       Please change your configuration to rename the variable (`{{ item.old }}` -> `{{ item.new }}`).