Use fully-qualified module names for builtin Ansible modules

Related to https://github.com/spantaleev/matrix-docker-ansible-deploy/pull/1939

roles/matrix-bridge-mautrix-twitter/tasks/init.yml

@@ -1,11 +1,11 @@
 ---
 
-- set_fact:
+- ansible.builtin.set_fact:
     matrix_systemd_services_list: "{{ matrix_systemd_services_list + ['matrix-mautrix-twitter.service'] }}"
   when: matrix_mautrix_twitter_enabled|bool
 
 # If the matrix-synapse role is not used, these variables may not exist.
-- set_fact:
+- ansible.builtin.set_fact:
     matrix_synapse_container_extra_arguments: >
       {{
         matrix_synapse_container_extra_arguments|default([])
@@ -24,6 +24,6 @@
 # ansible lower than 2.8, does not support docker_image build parameters
 # for self buildig it is explicitly needed, so we rather fail here
 - name: Fail if running on Ansible lower than 2.8 and trying self building
-  fail:
+  ansible.builtin.fail:
     msg: "To self build Mautrix Twitter image, you should usa ansible 2.8 or higher. E.g. pip contains such packages."
   when: "ansible_version.major == 2 and ansible_version.minor < 8 and matrix_mautrix_twitter_container_image_self_build"

roles/matrix-bridge-mautrix-twitter/tasks/setup_install.yml

@@ -3,12 +3,12 @@
 # If the matrix-synapse role is not used, `matrix_synapse_role_executed` won't exist.
 # We don't want to fail in such cases.
 - name: Fail if matrix-synapse role already executed
-  fail:
+  ansible.builtin.fail:
     msg: >-
       The matrix-bridge-mautrix-twitter role needs to execute before the matrix-synapse role.
   when: "matrix_synapse_role_executed|default(False)"
 
-- set_fact:
+- ansible.builtin.set_fact:
     matrix_mautrix_twitter_requires_restart: false
 
 - name: Ensure Mautrix Twitter image is pulled
@@ -24,7 +24,7 @@
   until: result is not failed
 
 - name: Ensure Mautrix Twitter paths exist
-  file:
+  ansible.builtin.file:
     path: "{{ item.path }}"
     state: directory
     mode: 0750
@@ -38,7 +38,7 @@
   when: item.when|bool
 
 - name: Ensure Mautrix Twitter repository is present on self-build
-  git:
+  ansible.builtin.git:
     repo: "{{ matrix_mautrix_twitter_container_image_self_build_repo }}"
     dest: "{{ matrix_mautrix_twitter_docker_src_files_path }}"
     # version: "{{ matrix_coturn_docker_image.split(':')[1] }}"
@@ -60,7 +60,7 @@
   when: "matrix_mautrix_twitter_enabled|bool and matrix_mautrix_twitter_container_image_self_build|bool"
 
 - name: Ensure mautrix-twitter config.yaml installed
-  copy:
+  ansible.builtin.copy:
     content: "{{ matrix_mautrix_twitter_configuration|to_nice_yaml(indent=2, width=999999) }}"
     dest: "{{ matrix_mautrix_twitter_config_path }}/config.yaml"
     mode: 0644
@@ -68,7 +68,7 @@
     group: "{{ matrix_user_groupname }}"
 
 - name: Ensure mautrix-twitter registration.yaml installed
-  copy:
+  ansible.builtin.copy:
     content: "{{ matrix_mautrix_twitter_registration|to_nice_yaml(indent=2, width=999999) }}"
     dest: "{{ matrix_mautrix_twitter_config_path }}/registration.yaml"
     mode: 0644
@@ -76,19 +76,19 @@
     group: "{{ matrix_user_groupname }}"
 
 - name: Ensure matrix-mautrix-twitter.service installed
-  template:
+  ansible.builtin.template:
     src: "{{ role_path }}/templates/systemd/matrix-mautrix-twitter.service.j2"
     dest: "{{ matrix_systemd_path }}/matrix-mautrix-twitter.service"
     mode: 0644
   register: matrix_mautrix_twitter_systemd_service_result
 
 - name: Ensure systemd reloaded after matrix-mautrix-twitter.service installation
-  service:
+  ansible.builtin.service:
     daemon_reload: true
   when: "matrix_mautrix_twitter_systemd_service_result.changed"
 
 - name: Ensure matrix-mautrix-twitter.service restarted, if necessary
-  service:
+  ansible.builtin.service:
     name: "matrix-mautrix-twitter.service"
     state: restarted
   when: "matrix_mautrix_twitter_requires_restart|bool"

roles/matrix-bridge-mautrix-twitter/tasks/setup_uninstall.yml

@@ -6,19 +6,19 @@
   register: matrix_mautrix_twitter_service_stat
 
 - name: Ensure matrix-mautrix-twitter is stopped
-  service:
+  ansible.builtin.service:
     name: matrix-mautrix-twitter
     state: stopped
     daemon_reload: true
   when: "matrix_mautrix_twitter_service_stat.stat.exists"
 
 - name: Ensure matrix-mautrix-twitter.service doesn't exist
-  file:
+  ansible.builtin.file:
     path: "{{ matrix_systemd_path }}/matrix-mautrix-twitter.service"
     state: absent
   when: "matrix_mautrix_twitter_service_stat.stat.exists"
 
 - name: Ensure systemd reloaded after matrix-mautrix-twitter.service removal
-  service:
+  ansible.builtin.service:
     daemon_reload: true
   when: "matrix_mautrix_twitter_service_stat.stat.exists"

roles/matrix-bridge-mautrix-twitter/tasks/validate_config.yml

@@ -1,7 +1,7 @@
 ---
 
 - name: Fail if required settings not defined
-  fail:
+  ansible.builtin.fail:
     msg: >-
       You need to define a required configuration setting (`{{ item }}`).
   when: "vars[item] == ''"