Use fully-qualified module names for builtin Ansible modules

Related to https://github.com/spantaleev/matrix-docker-ansible-deploy/pull/1939

roles/matrix-bridge-mx-puppet-twitter/tasks/init.yml

@@ -2,16 +2,16 @@
 # See https://github.com/spantaleev/matrix-docker-ansible-deploy/issues/1070
 # and https://github.com/spantaleev/matrix-docker-ansible-deploy/commit/1ab507349c752042d26def3e95884f6df8886b74#commitcomment-51108407
 - name: Fail if trying to self-build on Ansible < 2.8
-  fail:
+  ansible.builtin.fail:
     msg: "To self-build the Element image, you should use Ansible 2.8 or higher. See docs/ansible.md"
   when: "ansible_version.major == 2 and ansible_version.minor < 8 and matrix_mx_puppet_twitter_container_image_self_build and matrix_mx_puppet_twitter_enabled"
 
-- set_fact:
+- ansible.builtin.set_fact:
     matrix_systemd_services_list: "{{ matrix_systemd_services_list + ['matrix-mx-puppet-twitter.service'] }}"
   when: matrix_mx_puppet_twitter_enabled|bool
 
 # If the matrix-synapse role is not used, these variables may not exist.
-- set_fact:
+- ansible.builtin.set_fact:
     matrix_synapse_container_extra_arguments: >
       {{
         matrix_synapse_container_extra_arguments|default([])
@@ -29,7 +29,7 @@
 
 - block:
     - name: Fail if matrix-nginx-proxy role already executed
-      fail:
+      ansible.builtin.fail:
         msg: >-
           Trying to append Twitter Appservice's reverse-proxying configuration to matrix-nginx-proxy,
           but it's pointless since the matrix-nginx-proxy role had already executed.
@@ -38,7 +38,7 @@
       when: matrix_nginx_proxy_role_executed|default(False)|bool
 
     - name: Generate Matrix MX Puppet Twitter proxying configuration for matrix-nginx-proxy
-      set_fact:
+      ansible.builtin.set_fact:
         matrix_mx_puppet_twitter_matrix_nginx_proxy_configuration: |
           location {{ matrix_mx_puppet_twitter_webhook_path }} {
           {% if matrix_nginx_proxy_enabled|default(False) %}
@@ -53,7 +53,7 @@
           }
 
     - name: Register Twitter Appservice proxying configuration with matrix-nginx-proxy
-      set_fact:
+      ansible.builtin.set_fact:
         matrix_nginx_proxy_proxy_matrix_additional_server_configuration_blocks: |
           {{
             matrix_nginx_proxy_proxy_matrix_additional_server_configuration_blocks|default([])
@@ -65,7 +65,7 @@
   when: matrix_mx_puppet_twitter_enabled|bool
 
 - name: Warn about reverse-proxying if matrix-nginx-proxy not used
-  debug:
+  ansible.builtin.debug:
     msg: >-
       NOTE: You've enabled the Matrix Twitter bridge but are not using the matrix-nginx-proxy
       reverse proxy.

roles/matrix-bridge-mx-puppet-twitter/tasks/setup_install.yml

@@ -3,13 +3,13 @@
 # If the matrix-synapse role is not used, `matrix_synapse_role_executed` won't exist.
 # We don't want to fail in such cases.
 - name: Fail if matrix-synapse role already executed
-  fail:
+  ansible.builtin.fail:
     msg: >-
       The matrix-bridge-mx-puppet-twitter role needs to execute before the matrix-synapse role.
   when: "matrix_synapse_role_executed|default(False)"
 
 - name: Ensure MX Puppet Twitter paths exist
-  file:
+  ansible.builtin.file:
     path: "{{ item.path }}"
     state: directory
     mode: 0750
@@ -28,7 +28,7 @@
   register: matrix_mx_puppet_twitter_stat_database
 
 - name: (Data relocation) Ensure matrix-mx-puppet-twitter.service is stopped
-  service:
+  ansible.builtin.service:
     name: matrix-mx-puppet-twitter
     state: stopped
     enabled: false
@@ -37,10 +37,10 @@
   when: "matrix_mx_puppet_twitter_stat_database.stat.exists"
 
 - name: (Data relocation) Move mx-puppet-twitter database file to ./data directory
-  command: "mv {{ matrix_mx_puppet_twitter_base_path }}/database.db {{ matrix_mx_puppet_twitter_data_path }}/database.db"
+  ansible.builtin.command: "mv {{ matrix_mx_puppet_twitter_base_path }}/database.db {{ matrix_mx_puppet_twitter_data_path }}/database.db"
   when: "matrix_mx_puppet_twitter_stat_database.stat.exists"
 
-- set_fact:
+- ansible.builtin.set_fact:
     matrix_mx_puppet_twitter_requires_restart: false
 
 - block:
@@ -50,7 +50,7 @@
       register: matrix_mx_puppet_twitter_sqlite_database_path_local_stat_result
 
     - block:
-        - set_fact:
+        - ansible.builtin.set_fact:
             matrix_postgres_db_migration_request:
               src: "{{ matrix_mx_puppet_twitter_sqlite_database_path_local }}"
               dst: "{{ matrix_mx_puppet_twitter_database_connection_string }}"
@@ -61,7 +61,7 @@
 
         - import_tasks: "{{ role_path }}/../matrix-postgres/tasks/util/migrate_db_to_postgres.yml"
 
-        - set_fact:
+        - ansible.builtin.set_fact:
             matrix_mx_puppet_twitter_requires_restart: true
       when: "matrix_mx_puppet_twitter_sqlite_database_path_local_stat_result.stat.exists|bool"
   when: "matrix_mx_puppet_twitter_database_engine == 'postgres'"
@@ -79,7 +79,7 @@
   until: result is not failed
 
 - name: Ensure MX Puppet Twitter repository is present on self build
-  git:
+  ansible.builtin.git:
     repo: "{{ matrix_mx_puppet_twitter_container_image_self_build_repo }}"
     dest: "{{ matrix_mx_puppet_twitter_docker_src_files_path }}"
     force: "yes"
@@ -101,7 +101,7 @@
   when: "matrix_mx_puppet_twitter_enabled|bool and matrix_mx_puppet_twitter_container_image_self_build"
 
 - name: Ensure mx-puppet-twitter config.yaml installed
-  copy:
+  ansible.builtin.copy:
     content: "{{ matrix_mx_puppet_twitter_configuration|to_nice_yaml(indent=2, width=999999) }}"
     dest: "{{ matrix_mx_puppet_twitter_config_path }}/config.yaml"
     mode: 0644
@@ -109,7 +109,7 @@
     group: "{{ matrix_user_groupname }}"
 
 - name: Ensure mx-puppet-twitter twitter-registration.yaml installed
-  copy:
+  ansible.builtin.copy:
     content: "{{ matrix_mx_puppet_twitter_registration|to_nice_yaml(indent=2, width=999999) }}"
     dest: "{{ matrix_mx_puppet_twitter_config_path }}/registration.yaml"
     mode: 0644
@@ -117,19 +117,19 @@
     group: "{{ matrix_user_groupname }}"
 
 - name: Ensure matrix-mx-puppet-twitter.service installed
-  template:
+  ansible.builtin.template:
     src: "{{ role_path }}/templates/systemd/matrix-mx-puppet-twitter.service.j2"
     dest: "/etc/systemd/system/matrix-mx-puppet-twitter.service"
     mode: 0644
   register: matrix_mx_puppet_twitter_systemd_service_result
 
 - name: Ensure systemd reloaded after matrix-mx-puppet-twitter.service installation
-  service:
+  ansible.builtin.service:
     daemon_reload: true
   when: "matrix_mx_puppet_twitter_systemd_service_result.changed"
 
 - name: Ensure matrix-mx-puppet-twitter.service restarted, if necessary
-  service:
+  ansible.builtin.service:
     name: "matrix-mx-puppet-twitter.service"
     state: restarted
   when: "matrix_mx_puppet_twitter_requires_restart|bool"

roles/matrix-bridge-mx-puppet-twitter/tasks/setup_uninstall.yml

@@ -6,7 +6,7 @@
   register: matrix_mx_puppet_twitter_service_stat
 
 - name: Ensure matrix-mx-puppet-twitter is stopped
-  service:
+  ansible.builtin.service:
     name: matrix-mx-puppet-twitter
     state: stopped
     enabled: false
@@ -14,12 +14,12 @@
   when: "matrix_mx_puppet_twitter_service_stat.stat.exists"
 
 - name: Ensure matrix-mx-puppet-twitter.service doesn't exist
-  file:
+  ansible.builtin.file:
     path: "/etc/systemd/system/matrix-mx-puppet-twitter.service"
     state: absent
   when: "matrix_mx_puppet_twitter_service_stat.stat.exists"
 
 - name: Ensure systemd reloaded after matrix-mx-puppet-twitter.service removal
-  service:
+  ansible.builtin.service:
     daemon_reload: true
   when: "matrix_mx_puppet_twitter_service_stat.stat.exists"

roles/matrix-bridge-mx-puppet-twitter/tasks/validate_config.yml

@@ -1,7 +1,7 @@
 ---
 
 - name: Fail if required settings not defined
-  fail:
+  ansible.builtin.fail:
     msg: >-
       You need to define a required configuration setting (`{{ item }}`).
   when: "vars[item] == ''"