Use fully-qualified module names for builtin Ansible modules

Related to https://github.com/spantaleev/matrix-docker-ansible-deploy/pull/1939

roles/matrix-dendrite/tasks/dendrite/setup_install.yml

@@ -9,7 +9,7 @@
 # This is separate and conditional, to ensure we don't execute it
 # if the path already exists or we failed to check, because it's mounted using fuse.
 - name: Ensure Dendrite media store path exists
-  file:
+  ansible.builtin.file:
     path: "{{ matrix_dendrite_media_store_path }}"
     state: directory
     mode: 0750
@@ -37,7 +37,7 @@
 # We don't use the `docker_container` module, because using it with `cap_drop` requires
 # a very recent version, which is not available for a lot of people yet.
 - name: Generate Dendrite signing key
-  command: |
+  ansible.builtin.command: |
     docker run
     --rm
     --name=matrix-dendrite-config
@@ -48,14 +48,14 @@
   when: "not matrix_dendrite_signing_key_stat.stat.exists"
 
 - name: Ensure Dendrite server key exists
-  file:
+  ansible.builtin.file:
     path: "{{ matrix_dendrite_config_dir_path }}/{{ matrix_server_fqn_matrix }}.signing.pem"
     mode: 0644
     owner: "{{ matrix_user_username }}"
     group: "{{ matrix_user_groupname }}"
 
 - name: Ensure Dendrite configuration installed
-  copy:
+  ansible.builtin.copy:
     content: "{{ matrix_dendrite_configuration|to_nice_yaml(indent=2, width=999999) }}"
     dest: "{{ matrix_dendrite_config_dir_path }}/dendrite.yaml"
     mode: 0644
@@ -63,19 +63,19 @@
     group: "{{ matrix_user_groupname }}"
 
 - name: Ensure matrix-dendrite.service installed
-  template:
+  ansible.builtin.template:
     src: "{{ role_path }}/templates/dendrite/systemd/matrix-dendrite.service.j2"
     dest: "{{ matrix_systemd_path }}/matrix-dendrite.service"
     mode: 0644
   register: matrix_dendrite_systemd_service_result
 
 - name: Ensure systemd reloaded after matrix-dendrite.service installation
-  service:
+  ansible.builtin.service:
     daemon_reload: true
   when: "matrix_dendrite_systemd_service_result.changed|bool"
 
 - name: Ensure matrix-dendrite-create-account script created
-  template:
+  ansible.builtin.template:
     src: "{{ role_path }}/templates/dendrite/usr-local-bin/matrix-dendrite-create-account.j2"
     dest: "{{ matrix_local_bin_path }}/matrix-dendrite-create-account"
     mode: 0750

roles/matrix-dendrite/tasks/dendrite/setup_uninstall.yml

@@ -6,7 +6,7 @@
   register: matrix_dendrite_service_stat
 
 - name: Ensure matrix-dendrite is stopped
-  service:
+  ansible.builtin.service:
     name: matrix-dendrite
     state: stopped
     daemon_reload: true
@@ -14,13 +14,13 @@
   when: "matrix_dendrite_service_stat.stat.exists"
 
 - name: Ensure matrix-dendrite.service doesn't exist
-  file:
+  ansible.builtin.file:
     path: "{{ matrix_systemd_path }}/matrix-dendrite.service"
     state: absent
   when: "matrix_dendrite_service_stat.stat.exists"
 
 - name: Ensure systemd reloaded after matrix-dendrite.service removal
-  service:
+  ansible.builtin.service:
     daemon_reload: true
   when: "matrix_dendrite_service_stat.stat.exists"
 

roles/matrix-dendrite/tasks/init.yml

@@ -1,5 +1,5 @@
 ---
 
-- set_fact:
+- ansible.builtin.set_fact:
     matrix_systemd_services_list: "{{ matrix_systemd_services_list + ['matrix-dendrite.service'] }}"
   when: matrix_dendrite_enabled|bool

roles/matrix-dendrite/tasks/main.yml

@@ -36,7 +36,7 @@
     - self-check
 
 - name: Mark matrix-dendrite role as executed
-  set_fact:
+  ansible.builtin.set_fact:
     matrix_dendrite_role_executed: true
   tags:
     - always

roles/matrix-dendrite/tasks/register_user.yml

@@ -1,16 +1,16 @@
 ---
 - name: Fail if playbook called incorrectly
-  fail:
+  ansible.builtin.fail:
     msg: "The `username` variable needs to be provided to this playbook, via --extra-vars"
   when: "username is not defined or username == '<your-username>'"
 
 - name: Fail if playbook called incorrectly
-  fail:
+  ansible.builtin.fail:
     msg: "The `password` variable needs to be provided to this playbook, via --extra-vars"
   when: "password is not defined or password == '<your-password>'"
 
 - name: Ensure matrix-dendrite is started
-  service:
+  ansible.builtin.service:
     name: matrix-dendrite
     state: started
     daemon_reload: true
@@ -22,4 +22,4 @@
   when: "start_result.changed"
 
 - name: Register user
-  command: "{{ matrix_local_bin_path }}/matrix-dendrite-create-account {{ username|quote }} {{ password|quote }}"
+  ansible.builtin.command: "{{ matrix_local_bin_path }}/matrix-dendrite-create-account {{ username|quote }} {{ password|quote }}"

roles/matrix-dendrite/tasks/self_check_client_api.yml

@@ -1,6 +1,6 @@
 ---
 - name: Check Matrix Client API
-  uri:
+  ansible.builtin.uri:
     url: "{{ matrix_dendrite_client_api_url_endpoint_public }}"
     follow_redirects: none
     validate_certs: "{{ matrix_dendrite_self_check_validate_certificates }}"
@@ -9,10 +9,10 @@
   check_mode: false
 
 - name: Fail if Matrix Client API not working
-  fail:
+  ansible.builtin.fail:
     msg: "Failed checking Matrix Client API is up at `{{ matrix_server_fqn_matrix }}` (checked endpoint: `{{ matrix_dendrite_client_api_url_endpoint_public }}`). Is Dendrite running? Is port 443 open in your firewall? Full error: {{ result_matrix_dendrite_client_api }}"
   when: "(result_matrix_dendrite_client_api.failed or 'json' not in result_matrix_dendrite_client_api)"
 
 - name: Report working Matrix Client API
-  debug:
+  ansible.builtin.debug:
     msg: "The Matrix Client API at `{{ matrix_server_fqn_matrix }}` (checked endpoint: `{{ matrix_dendrite_client_api_url_endpoint_public }}`) is working"

roles/matrix-dendrite/tasks/self_check_federation_api.yml

@@ -1,6 +1,6 @@
 ---
 - name: Check Matrix Federation API
-  uri:
+  ansible.builtin.uri:
     url: "{{ matrix_dendrite_federation_api_url_endpoint_public }}"
     follow_redirects: none
     validate_certs: "{{ matrix_dendrite_self_check_validate_certificates }}"
@@ -9,16 +9,16 @@
   check_mode: false
 
 - name: Fail if Matrix Federation API not working
-  fail:
+  ansible.builtin.fail:
     msg: "Failed checking Matrix Federation API is up at `{{ matrix_server_fqn_matrix }}` (checked endpoint: `{{ matrix_dendrite_federation_api_url_endpoint_public }}`). Is Dendrite running? Is port {{ matrix_federation_public_port }} open in your firewall? Full error: {{ result_matrix_dendrite_federation_api }}"
   when: "matrix_dendrite_federation_enabled|bool and (result_matrix_dendrite_federation_api.failed or 'json' not in result_matrix_dendrite_federation_api)"
 
 - name: Fail if Matrix Federation API unexpectedly enabled
-  fail:
+  ansible.builtin.fail:
     msg: "Matrix Federation API is up at `{{ matrix_server_fqn_matrix }}` (checked endpoint: `{{ matrix_dendrite_federation_api_url_endpoint_public }}`) despite being disabled."
   when: "not matrix_dendrite_federation_enabled|bool and not result_matrix_dendrite_federation_api.failed"
 
 - name: Report working Matrix Federation API
-  debug:
+  ansible.builtin.debug:
     msg: "The Matrix Federation API at `{{ matrix_server_fqn_matrix }}` (checked endpoint: `{{ matrix_dendrite_federation_api_url_endpoint_public }}`) is working"
   when: "matrix_dendrite_federation_enabled|bool"

roles/matrix-dendrite/tasks/setup_dendrite.yml

@@ -1,6 +1,6 @@
 ---
 - name: Ensure Dendrite paths exist
-  file:
+  ansible.builtin.file:
     path: "{{ item.path }}"
     state: directory
     mode: 0750

roles/matrix-dendrite/tasks/validate_config.yml

@@ -1,6 +1,6 @@
 ---
 - name: Fail if required Dendrite settings not defined
-  fail:
+  ansible.builtin.fail:
     msg: >-
       You need to define a required configuration setting (`{{ item }}`) for using Dendrite.
   when: "vars[item] == ''"
@@ -8,7 +8,7 @@
     - "matrix_dendrite_registration_shared_secret"
 
 - name: (Deprecation) Catch and report renamed settings
-  fail:
+  ansible.builtin.fail:
     msg: >-
       Your configuration contains a variable, which now has a different name.
       Please change your configuration to rename the variable (`{{ item.old }}` -> `{{ item.new }}`).