Use fully-qualified module names for builtin Ansible modules

Related to https://github.com/spantaleev/matrix-docker-ansible-deploy/pull/1939

roles/matrix-postgres/tasks/util/create_additional_database.yml

@@ -3,7 +3,7 @@
 # It'd be better if this is belonged to `validate_config.yml`, but it would have to be some loop-within-a-loop there,
 # and that's ugly. We also don't expect this to catch errors often. It's more of a defensive last-minute check.
 - name: Fail if additional database data appears invalid
-  fail:
+  ansible.builtin.fail:
     msg: "Additional database definition ({{ additional_db }} lacks a required key: {{ item }}"
   when: "item not in additional_db"
   with_items: "{{ ['name', 'username', 'password'] }}"
@@ -12,7 +12,7 @@
 # This file will be mounted into the container and fed to Postgres.
 # This way, we avoid passing sensitive data around in CLI commands that other users on the system can see.
 - name: Create additional database initialization SQL file for {{ additional_db.name }}
-  template:
+  ansible.builtin.template:
     src: "{{ role_path }}/templates/sql/init-additional-db-user-and-role.sql.j2"
     dest: "/tmp/matrix-postgres-init-additional-db-user-and-role.sql"
     mode: 0600
@@ -20,7 +20,7 @@
     group: "{{ matrix_user_gid }}"
 
 - name: Execute Postgres additional database initialization SQL file for {{ additional_db.name }}
-  command:
+  ansible.builtin.command:
     cmd: >-
       {{ matrix_host_command_docker }} run
       --rm
@@ -35,6 +35,6 @@
       'psql -h {{ matrix_postgres_connection_hostname }} --file=/matrix-postgres-init-additional-db-user-and-role.sql'
 
 - name: Delete additional database initialization SQL file for {{ additional_db.name }}
-  file:
+  ansible.builtin.file:
     path: /tmp/matrix-postgres-init-additional-db-user-and-role.sql
     state: absent

roles/matrix-postgres/tasks/util/create_additional_databases.yml

@@ -1,7 +1,7 @@
 ---
 
 - name: Ensure matrix-postgres is started
-  service:
+  ansible.builtin.service:
     name: matrix-postgres
     state: started
     daemon_reload: true

roles/matrix-postgres/tasks/util/detect_existing_postgres_version.yml

@@ -4,7 +4,7 @@
 # If there is, it also tries to detect the Docker image that corresponds to that version.
 
 - name: Initialize Postgres version determination variables (default to empty)
-  set_fact:
+  ansible.builtin.set_fact:
     matrix_postgres_detection_pg_version_path: "{{ matrix_postgres_data_path }}/PG_VERSION"
     matrix_postgres_detected_existing: false
     matrix_postgres_detected_version: ""
@@ -15,47 +15,47 @@
     path: "{{ matrix_postgres_detection_pg_version_path }}"
   register: result_pg_version_stat
 
-- set_fact:
+- ansible.builtin.set_fact:
     matrix_postgres_detected_existing: true
   when: "result_pg_version_stat.stat.exists"
 
 - name: Determine existing Postgres version (read PG_VERSION file)
-  slurp:
+  ansible.builtin.slurp:
     src: "{{ matrix_postgres_detection_pg_version_path }}"
   register: result_pg_version
   when: matrix_postgres_detected_existing|bool
 
 - name: Determine existing Postgres version (make sense of PG_VERSION file)
-  set_fact:
+  ansible.builtin.set_fact:
     matrix_postgres_detected_version: "{{ result_pg_version['content']|b64decode|replace('\n', '') }}"
   when: matrix_postgres_detected_existing|bool
 
 - name: Determine corresponding Docker image to detected version (assume default of latest)
-  set_fact:
+  ansible.builtin.set_fact:
     matrix_postgres_detected_version_corresponding_docker_image: "{{ matrix_postgres_docker_image_latest }}"
   when: "matrix_postgres_detected_version != ''"
 
 - name: Determine corresponding Docker image to detected version (use 9.x, if detected)
-  set_fact:
+  ansible.builtin.set_fact:
     matrix_postgres_detected_version_corresponding_docker_image: "{{ matrix_postgres_docker_image_v9 }}"
   when: "matrix_postgres_detected_version.startswith('9.')"
 
 - name: Determine corresponding Docker image to detected version (use 10.x, if detected)
-  set_fact:
+  ansible.builtin.set_fact:
     matrix_postgres_detected_version_corresponding_docker_image: "{{ matrix_postgres_docker_image_v10 }}"
   when: "matrix_postgres_detected_version == '10' or matrix_postgres_detected_version.startswith('10.')"
 
 - name: Determine corresponding Docker image to detected version (use 11.x, if detected)
-  set_fact:
+  ansible.builtin.set_fact:
     matrix_postgres_detected_version_corresponding_docker_image: "{{ matrix_postgres_docker_image_v11 }}"
   when: "matrix_postgres_detected_version == '11' or matrix_postgres_detected_version.startswith('11.')"
 
 - name: Determine corresponding Docker image to detected version (use 12.x, if detected)
-  set_fact:
+  ansible.builtin.set_fact:
     matrix_postgres_detected_version_corresponding_docker_image: "{{ matrix_postgres_docker_image_v12 }}"
   when: "matrix_postgres_detected_version == '12' or matrix_postgres_detected_version.startswith('12.')"
 
 - name: Determine corresponding Docker image to detected version (use 13.x, if detected)
-  set_fact:
+  ansible.builtin.set_fact:
     matrix_postgres_detected_version_corresponding_docker_image: "{{ matrix_postgres_docker_image_v13 }}"
   when: "matrix_postgres_detected_version == '13' or matrix_postgres_detected_version.startswith('13.')"

roles/matrix-postgres/tasks/util/migrate_db_to_postgres.yml

@@ -1,17 +1,17 @@
 ---
 
 - name: Fail if Postgres not enabled
-  fail:
+  ansible.builtin.fail:
     msg: "Postgres via the matrix-postgres role is not enabled (`matrix_postgres_enabled`). Cannot migrate."
   when: "not matrix_postgres_enabled|bool"
 
 - name: Fail if util called incorrectly (missing matrix_postgres_db_migration_request)
-  fail:
+  ansible.builtin.fail:
     msg: "The `matrix_postgres_db_migration_request` variable needs to be provided to this util."
   when: "matrix_postgres_db_migration_request is not defined"
 
 - name: Fail if util called incorrectly (invalid matrix_postgres_db_migration_request)
-  fail:
+  ansible.builtin.fail:
     msg: "The `matrix_postgres_db_migration_request` variable needs to contain `{{ item }}`."
   with_items:
     - src
@@ -27,13 +27,13 @@
   register: matrix_postgres_db_migration_request_src_stat_result
 
 - name: Fail if provided source database file doesn't exist
-  fail:
+  ansible.builtin.fail:
     msg: "File cannot be found on the server at {{ matrix_postgres_db_migration_request.src }}"
   when: "not matrix_postgres_db_migration_request_src_stat_result.stat.exists"
 
 - block:
     - name: Ensure pgloader repository is present on self-build
-      git:
+      ansible.builtin.git:
         repo: "{{ matrix_postgres_pgloader_container_image_self_build_repo }}"
         dest: "{{ matrix_postgres_pgloader_container_image_self_build_src_path }}"
         version: "{{ matrix_postgres_pgloader_container_image_self_build_repo_branch }}"
@@ -49,7 +49,7 @@
     #
     # Although we're not using the dimitri/pgloader image, the one we're using suffers from the same problem.
     - name: Switch pgloader base image from Debian stable (likely 10.x/Buster) to Bullseye
-      lineinfile:
+      ansible.builtin.lineinfile:
         path: "{{ matrix_postgres_pgloader_container_image_self_build_src_path }}/Dockerfile"
         regexp: "{{ item.match }}"
         line: "{{ item.replace }}"
@@ -82,7 +82,7 @@
 # Defaults
 
 - name: Set postgres_start_wait_time, if not provided
-  set_fact:
+  ansible.builtin.set_fact:
     postgres_start_wait_time: 15
   when: "postgres_start_wait_time|default('') == ''"
 
@@ -90,7 +90,7 @@
 
 # matrix-postgres is most likely started already
 - name: Ensure matrix-postgres is started
-  service:
+  ansible.builtin.service:
     name: matrix-postgres
     state: started
     daemon_reload: true
@@ -112,14 +112,14 @@
 # However, we don't do it, because it's simpler having it here, and it also gets to happen only if we'll be doing an import.
 # If we bailed out (somewhere above), nothing would have gotten stopped. It's nice to leave this running in such cases.
 - name: Ensure systemd services blocking the database import are stopped
-  service:
+  ansible.builtin.service:
     name: "{{ item }}"
     state: stopped
   failed_when: false
   with_items: "{{ matrix_postgres_db_migration_request.systemd_services_to_stop }}"
 
 - name: Import {{ matrix_postgres_db_migration_request.engine_old }} database from {{ matrix_postgres_db_migration_request.src }} into Postgres
-  command:
+  ansible.builtin.command:
     cmd: >-
       {{ matrix_host_command_docker }} run
       --rm
@@ -137,11 +137,11 @@
     # because it refers to the role that included this util, and not to the role this file belongs to.
     - import_tasks: "{{ role_path }}/../matrix-postgres/tasks/util/detect_existing_postgres_version.yml"
 
-    - set_fact:
+    - ansible.builtin.set_fact:
         matrix_postgres_docker_image_to_use: "{{ matrix_postgres_docker_image_latest if matrix_postgres_detected_version_corresponding_docker_image == '' else matrix_postgres_detected_version_corresponding_docker_image }}"
 
     - name: Execute additional Postgres SQL migration statements
-      command:
+      ansible.builtin.command:
         cmd: >-
           {{ matrix_host_command_docker }} run
           --rm
@@ -156,11 +156,11 @@
   when: "matrix_postgres_db_migration_request.additional_psql_statements_list|default([])|length > 0"
 
 - name: Archive {{ matrix_postgres_db_migration_request.engine_old }} database ({{ matrix_postgres_db_migration_request.src }} -> {{ matrix_postgres_db_migration_request.src }}.backup)
-  command:
+  ansible.builtin.command:
     cmd: "mv {{ matrix_postgres_db_migration_request.src }} {{ matrix_postgres_db_migration_request.src }}.backup"
 
 - name: Inject result
-  set_fact:
+  ansible.builtin.set_fact:
     matrix_playbook_runtime_results: |
       {{
         matrix_playbook_runtime_results|default([])