finallycoffee/matrix-docker-ansible-deploy
finallycoffee/matrix-docker-ansible-deploy
5
1
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Revert "Don't self-build ma1sd every time unless git sources changed"

Browse Source 
This reverts commit 2a25b63bb6.

Looking at other roles, we trigger building regardless of this.
It's better to always trigger it, because it's less fragile.
If the build fails and we only trigger it on "git changes"
then we won't trigger it for a while. That's not good.

Triggering it each and every time may seem like a waste,
but it supposedly runs quickly due to Docker caching.
This commit is contained in:
Slavi Pantaleev 2021-01-14 22:20:51 +02:00
parent 6f5aaad48d
commit 653d1d7924
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
roles/matrix-ma1sd/tasks/setup_install.yml
View File

@ -87,7 +87,6 @@
shell: "./gradlew dockerBuild" shell: "./gradlew dockerBuild"
args: args:
chdir: "{{ matrix_ma1sd_docker_src_files_path }}" chdir: "{{ matrix_ma1sd_docker_src_files_path }}"
when: "matrix_ma1sd_git_pull_results.changed|bool"
- name: Ensure ma1sd Docker image is tagged correctly - name: Ensure ma1sd Docker image is tagged correctly
docker_image: docker_image:
@ -98,7 +97,6 @@
repository: "{{ matrix_ma1sd_docker_image }}" repository: "{{ matrix_ma1sd_docker_image }}"
force_tag: yes force_tag: yes
source: local source: local
when: "matrix_ma1sd_git_pull_results.changed|bool"
when: "matrix_ma1sd_container_image_self_build|bool" when: "matrix_ma1sd_container_image_self_build|bool"
- name: Ensure ma1sd config installed - name: Ensure ma1sd config installed