finallycoffee/matrix-docker-ansible-deploy
5
1
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix validation message

Browse Source 
The check was checking for an empty string in `matrix_jitsi_prosody_auth_internal_accounts`,
which is unlikely to happen. We should check for an empty list instead.

The check was not validating username/password values, so telling the user that they need a non-empty
username/password is misleading. It was merely checking if there's at least one entry in the list.

This patch adjusts the check and message accordingly.
This commit is contained in:
Slavi Pantaleev
2021-12-11 10:14:33 +02:00
committed by GitHub
parent c116f268f2
commit 6568b68759
1 changed files with 2 additions and 4 deletions

6
roles/matrix-jitsi/tasks/validate_config.yml

@ -23,16 +23,14 @@
- name: Fail if a Jitsi internal authentication account is not defined - name: Fail if a Jitsi internal authentication account is not defined
fail: fail:
msg: >- msg: >-
Each Jitsi user in `matrix_jitsi_prosody_auth_internal_accounts` needs to have a non-empty `username`/`password`. At least one Jitsi user needs to be defined in `matrix_jitsi_prosody_auth_internal_accounts` when using internal authentication.
Please ensure you have defined at least one user and password when using internal authentication.
If you're setting up Jitsi for the first time, you may have missed a step. If you're setting up Jitsi for the first time, you may have missed a step.
Refer to our setup instructions (docs/configuring-playbook-jitsi.md). Refer to our setup instructions (docs/configuring-playbook-jitsi.md).
when: when:
- matrix_jitsi_enable_auth|bool - matrix_jitsi_enable_auth|bool
- matrix_jitsi_auth_type == 'internal' - matrix_jitsi_auth_type == 'internal'
- matrix_jitsi_prosody_auth_internal_accounts == '' - matrix_jitsi_prosody_auth_internal_accounts|length == 0
- name: (Deprecation) Catch and report renamed settings - name: (Deprecation) Catch and report renamed settings