fix: all praise the allmighty yamllinter

roles/matrix-bridge-appservice-webhooks/tasks/init.yml

@@ -1,3 +1,4 @@
+---
 # If the matrix-synapse role is not used, `matrix_synapse_role_executed` won't exist.
 # We don't want to fail in such cases.
 - name: Fail if matrix-synapse role already executed
@@ -32,42 +33,42 @@
   when: "matrix_synapse_role_executed|default(False)"
 
 - block:
-  - name: Fail if matrix-nginx-proxy role already executed
-    fail:
-      msg: >-
-        Trying to append webhooks Appservice's reverse-proxying configuration to matrix-nginx-proxy,
-        but it's pointless since the matrix-nginx-proxy role had already executed.
-        To fix this, please change the order of roles in your playbook,
-        so that the matrix-nginx-proxy role would run after the matrix-bridge-appservice-webhooks role.
-    when: matrix_nginx_proxy_role_executed|default(False)|bool
+    - name: Fail if matrix-nginx-proxy role already executed
+      fail:
+        msg: >-
+          Trying to append webhooks Appservice's reverse-proxying configuration to matrix-nginx-proxy,
+          but it's pointless since the matrix-nginx-proxy role had already executed.
+          To fix this, please change the order of roles in your playbook,
+          so that the matrix-nginx-proxy role would run after the matrix-bridge-appservice-webhooks role.
+      when: matrix_nginx_proxy_role_executed|default(False)|bool
 
-  - name: Generate Matrix Appservice webhooks proxying configuration for matrix-nginx-proxy
-    set_fact:
-      matrix_appservice_webhooks_matrix_nginx_proxy_configuration: |
-        {% if matrix_nginx_proxy_enabled|default(False) %}
-        {# Use the embedded DNS resolver in Docker containers to discover the service #}
-        location ~ ^{{ matrix_appservice_webhooks_public_endpoint }}/(.*)$ {
-          resolver 127.0.0.11 valid=5s;
-          set $backend "matrix-appservice-webhooks:{{ matrix_appservice_webhooks_matrix_port }}";
-          proxy_pass http://$backend/$1;
-        }
-        {% else %}
-        {# Generic configuration for use outside of our container setup #}
-        location {{ matrix_appservice_webhooks_public_endpoint }}/ {
-          proxy_pass http://127.0.0.1:{{ matrix_appservice_webhooks_matrix_port }}/;
-        }
-        {% endif %}
+    - name: Generate Matrix Appservice webhooks proxying configuration for matrix-nginx-proxy
+      set_fact:
+        matrix_appservice_webhooks_matrix_nginx_proxy_configuration: |
+          {% if matrix_nginx_proxy_enabled|default(False) %}
+          {# Use the embedded DNS resolver in Docker containers to discover the service #}
+          location ~ ^{{ matrix_appservice_webhooks_public_endpoint }}/(.*)$ {
+            resolver 127.0.0.11 valid=5s;
+            set $backend "matrix-appservice-webhooks:{{ matrix_appservice_webhooks_matrix_port }}";
+            proxy_pass http://$backend/$1;
+          }
+          {% else %}
+          {# Generic configuration for use outside of our container setup #}
+          location {{ matrix_appservice_webhooks_public_endpoint }}/ {
+            proxy_pass http://127.0.0.1:{{ matrix_appservice_webhooks_matrix_port }}/;
+          }
+          {% endif %}
 
-  - name: Register webhooks Appservice proxying configuration with matrix-nginx-proxy
-    set_fact:
-      matrix_nginx_proxy_proxy_matrix_additional_server_configuration_blocks: |
-        {{
-          matrix_nginx_proxy_proxy_matrix_additional_server_configuration_blocks|default([])
-          +
-          [matrix_appservice_webhooks_matrix_nginx_proxy_configuration]
-        }}
+    - name: Register webhooks Appservice proxying configuration with matrix-nginx-proxy
+      set_fact:
+        matrix_nginx_proxy_proxy_matrix_additional_server_configuration_blocks: |
+          {{
+            matrix_nginx_proxy_proxy_matrix_additional_server_configuration_blocks|default([])
+            +
+            [matrix_appservice_webhooks_matrix_nginx_proxy_configuration]
+          }}
   tags:
-   - always
+    - always
   when: matrix_appservice_webhooks_enabled|bool
 
 - name: Warn about reverse-proxying if matrix-nginx-proxy not used

roles/matrix-bridge-appservice-webhooks/tasks/main.yml

@@ -1,3 +1,5 @@
+---
+
 - import_tasks: "{{ role_path }}/tasks/init.yml"
   tags:
     - always

roles/matrix-bridge-appservice-webhooks/tasks/setup_install.yml

@@ -8,10 +8,10 @@
     owner: "{{ matrix_user_username }}"
     group: "{{ matrix_user_groupname }}"
   with_items:
-    - { path: "{{ matrix_appservice_webhooks_base_path }}", when: true }
-    - { path: "{{ matrix_appservice_webhooks_config_path }}", when: true }
-    - { path: "{{ matrix_appservice_webhooks_data_path }}", when: true }
-    - { path: "{{ matrix_appservice_webhooks_docker_src_files_path }}", when: "{{ matrix_appservice_webhooks_container_image_self_build }}"}
+    - {path: "{{ matrix_appservice_webhooks_base_path }}", when: true}
+    - {path: "{{ matrix_appservice_webhooks_config_path }}", when: true}
+    - {path: "{{ matrix_appservice_webhooks_data_path }}", when: true}
+    - {path: "{{ matrix_appservice_webhooks_docker_src_files_path }}", when: "{{ matrix_appservice_webhooks_container_image_self_build }}"}
   when: "item.when|bool"
 
 - name: Ensure Appservice webhooks image is pulled
@@ -40,7 +40,7 @@
         build:
           dockerfile: "{{ matrix_appservice_webhooks_container_image_self_build_repo_dockerfile_path }}"
           path: "{{ matrix_appservice_webhooks_docker_src_files_path }}"
-          pull: yes
+          pull: true
   when: "matrix_appservice_webhooks_container_image_self_build|bool"
 
 - name: Ensure Matrix Appservice webhooks config is installed
@@ -84,5 +84,5 @@
 
 - name: Ensure systemd reloaded after matrix-appservice-webhooks.service installation
   service:
-    daemon_reload: yes
+    daemon_reload: true
   when: "matrix_appservice_webhooks_systemd_service_result.changed"

roles/matrix-bridge-appservice-webhooks/tasks/setup_uninstall.yml

@@ -9,8 +9,8 @@
   service:
     name: matrix-appservice-webhooks
     state: stopped
-    enabled: no
-    daemon_reload: yes
+    enabled: false
+    daemon_reload: true
   when: "matrix_appservice_webhooks_service_stat.stat.exists"
 
 - name: Ensure matrix-appservice-webhooks.service doesn't exist
@@ -21,5 +21,5 @@
 
 - name: Ensure systemd reloaded after matrix-appservice-webhooks.service removal
   service:
-    daemon_reload: yes
+    daemon_reload: true
   when: "matrix_appservice_webhooks_service_stat.stat.exists"