fix: all praise the allmighty yamllinter

roles/matrix-common-after/defaults/main.yml

@@ -1,3 +1,4 @@
+---
 # Specifies how long to wait between starting systemd services and checking if they're started.
 #
 # A too low value may lead to a failure, as services may not have enough time to start and potentially fail.

roles/matrix-common-after/tasks/awx_post.yml

@@ -6,7 +6,7 @@
   register: cmd
   when: not awx_janitor_user_created|bool
   no_log: false
-    
+
 - name: Update AWX janitor user created variable
   delegate_to: 127.0.0.1
   lineinfile:
@@ -24,7 +24,7 @@
   register: cmd
   when: not awx_dimension_user_created|bool
   no_log: false
-  
+
 - name: Update AWX dimension user created variable
   delegate_to: 127.0.0.1
   lineinfile:
@@ -42,7 +42,7 @@
   register: cmd
   when: not awx_mjolnir_user_created|bool
   no_log: false
-  
+
 - name: Update AWX dimension user created variable
   delegate_to: 127.0.0.1
   lineinfile:

roles/matrix-common-after/tasks/dump_runtime_results.yml

@@ -1,3 +1,4 @@
+---
 # Ansible outputs the message in the `item=` field.
 # It's unnecessary to output it again in the actual message, so we don't.
 - debug:

roles/matrix-common-after/tasks/main.yml

@@ -1,3 +1,4 @@
+---
 
 - import_tasks: "{{ role_path }}/tasks/start.yml"
   when: run_start|bool
@@ -12,7 +13,7 @@
 - import_tasks: "{{ role_path }}/tasks/dump_runtime_results.yml"
   tags:
     - always
-    
+
 - import_tasks: "{{ role_path }}/tasks/awx_post.yml"
   when: run_setup|bool and matrix_awx_enabled|bool
   tags:
@@ -21,5 +22,3 @@
 - import_tasks: "{{ role_path }}/tasks/run_docker_prune.yml"
   tags:
     - run-docker-prune
-    
-

roles/matrix-common-after/tasks/start.yml

@@ -6,7 +6,7 @@
 
 - name: Ensure systemd is reloaded
   service:
-    daemon_reload: yes
+    daemon_reload: true
 
 - name: Ensure Matrix services are stopped
   service:
@@ -35,39 +35,39 @@
   become: false
 
 - block:
-  - name: Populate service facts
-    service_facts:
+    - name: Populate service facts
+      service_facts:
 
-  - name: Fail if service isn't detected to be running
-    fail:
-      msg: >-
-        {{ item }} was not detected to be running.
-        It's possible that there's a configuration problem or another service on your server interferes with it (uses the same ports, etc.).
-        Try running `systemctl status {{ item }}` and `journalctl -fu {{ item }}` on the server to investigate.
-        If you're on a slow or overloaded server, it may be that services take a longer time to start and that this error is a false-positive.
-        You can consider raising the value of the `matrix_common_after_systemd_service_start_wait_for_timeout_seconds` variable.
-        See `roles/matrix-common-after/defaults/main.yml` for more details about that.
-    with_items: "{{ matrix_systemd_services_list }}"
-    when:
-      - "item.endswith('.service') and (ansible_facts.services[item]|default(none) is none or ansible_facts.services[item].state != 'running')"
+    - name: Fail if service isn't detected to be running
+      fail:
+        msg: >-
+          {{ item }} was not detected to be running.
+          It's possible that there's a configuration problem or another service on your server interferes with it (uses the same ports, etc.).
+          Try running `systemctl status {{ item }}` and `journalctl -fu {{ item }}` on the server to investigate.
+          If you're on a slow or overloaded server, it may be that services take a longer time to start and that this error is a false-positive.
+          You can consider raising the value of the `matrix_common_after_systemd_service_start_wait_for_timeout_seconds` variable.
+          See `roles/matrix-common-after/defaults/main.yml` for more details about that.
+      with_items: "{{ matrix_systemd_services_list }}"
+      when:
+        - "item.endswith('.service') and (ansible_facts.services[item]|default(none) is none or ansible_facts.services[item].state != 'running')"
   when: " ansible_distribution != 'Archlinux'"
 
 - block:
-  # Currently there is a bug in ansible that renders is incompatible with systemd.
-  # service_facts is not collecting the data successfully.
-  # Therefore iterating here manually
-  - name: Fetch systemd information
-    systemd:
-      name: "{{ item }}"
-    register: systemdstatus
-    with_items: "{{ matrix_systemd_services_list }}"
+    # Currently there is a bug in ansible that renders is incompatible with systemd.
+    # service_facts is not collecting the data successfully.
+    # Therefore iterating here manually
+    - name: Fetch systemd information
+      systemd:
+        name: "{{ item }}"
+      register: systemdstatus
+      with_items: "{{ matrix_systemd_services_list }}"
 
-  - name: Fail if service isn't detected to be running
-    fail:
-      msg: >-
-        {{ item.item }} was not detected to be running.
-        It's possible that there's a configuration problem or another service on your server interferes with it (uses the same ports, etc.).
-        Try running `systemctl status {{ item.item }}` and `journalctl -fu {{ item.item }}` on the server to investigate.
-    with_items: "{{ systemdstatus.results }}"
-    when: "item.status['ActiveState'] != 'active'"
+    - name: Fail if service isn't detected to be running
+      fail:
+        msg: >-
+          {{ item.item }} was not detected to be running.
+          It's possible that there's a configuration problem or another service on your server interferes with it (uses the same ports, etc.).
+          Try running `systemctl status {{ item.item }}` and `journalctl -fu {{ item.item }}` on the server to investigate.
+      with_items: "{{ systemdstatus.results }}"
+      when: "item.status['ActiveState'] != 'active'"
   when: "ansible_distribution == 'Archlinux'"