fix: all praise the allmighty yamllinter

roles/matrix-ma1sd/defaults/main.yml

@@ -1,3 +1,4 @@
+---
 # ma1sd is a Federated Matrix Identity Server
 # See: https://github.com/ma1uta/ma1sd
 

roles/matrix-ma1sd/tasks/init.yml

@@ -1,3 +1,4 @@
+---
 # See https://github.com/spantaleev/matrix-docker-ansible-deploy/issues/1070
 # and https://github.com/spantaleev/matrix-docker-ansible-deploy/commit/1ab507349c752042d26def3e95884f6df8886b74#commitcomment-51108407
 - name: Fail if trying to self-build on Ansible < 2.8

roles/matrix-ma1sd/tasks/main.yml

@@ -1,3 +1,5 @@
+---
+
 - import_tasks: "{{ role_path }}/tasks/init.yml"
   tags:
     - always

roles/matrix-ma1sd/tasks/migrate_mxisd.yml

@@ -23,8 +23,8 @@
   service:
     name: matrix-mxisd
     state: stopped
-    enabled: no
-    daemon_reload: yes
+    enabled: false
+    daemon_reload: true
   when: "matrix_mxisd_service_stat.stat.exists"
 
 - name: Check existence of matrix-ma1sd service
@@ -37,26 +37,26 @@
   service:
     name: matrix-ma1sd
     state: stopped
-    daemon_reload: yes
+    daemon_reload: true
   when: "ma1sd_migrate_mxisd_data_dir_stat.stat.exists and matrix_ma1sd_service_stat.stat.exists"
 
 # We use shell commands for the migration, because the Ansible copy module cannot
 # recursively copy remote directories (like `/matrix/mxisd/data/sign.key`) in older versions of Ansible.
 - block:
-  - name: Copy mxisd data files to ma1sd folder
-    command: "cp -ar {{ matrix_base_data_path }}/mxisd/data {{ matrix_ma1sd_base_path }}"
+    - name: Copy mxisd data files to ma1sd folder
+      command: "cp -ar {{ matrix_base_data_path }}/mxisd/data {{ matrix_ma1sd_base_path }}"
 
-  - name: Check existence of mxisd.db file
-    stat:
-      path: "{{ matrix_ma1sd_data_path }}/mxisd.db"
-    register: matrix_ma1sd_mxisd_db_stat
+    - name: Check existence of mxisd.db file
+      stat:
+        path: "{{ matrix_ma1sd_data_path }}/mxisd.db"
+      register: matrix_ma1sd_mxisd_db_stat
 
-  - name: Rename database (mxisd.db -> ma1sd.db)
-    command: "mv {{ matrix_ma1sd_data_path }}/mxisd.db {{ matrix_ma1sd_data_path }}/ma1sd.db"
-    when: "matrix_ma1sd_mxisd_db_stat.stat.exists"
+    - name: Rename database (mxisd.db -> ma1sd.db)
+      command: "mv {{ matrix_ma1sd_data_path }}/mxisd.db {{ matrix_ma1sd_data_path }}/ma1sd.db"
+      when: "matrix_ma1sd_mxisd_db_stat.stat.exists"
 
-  - name: Rename mxisd folder
-    command: "mv {{ matrix_base_data_path }}/mxisd {{ matrix_base_data_path }}/mxisd.migrated"
+    - name: Rename mxisd folder
+      command: "mv {{ matrix_base_data_path }}/mxisd {{ matrix_base_data_path }}/mxisd.migrated"
   when: "ma1sd_migrate_mxisd_data_dir_stat.stat.exists"
 
 - name: Ensure outdated matrix-mxisd.service doesn't exist
@@ -67,7 +67,5 @@
 
 - name: Ensure systemd reloaded after removing outdated matrix-mxisd.service
   service:
-    daemon_reload: yes
+    daemon_reload: true
   when: "matrix_mxisd_service_stat.stat.exists"
-
-

roles/matrix-ma1sd/tasks/self_check_ma1sd.yml

@@ -8,7 +8,7 @@
     url: "{{ ma1sd_url_endpoint_public }}"
     follow_redirects: none
     validate_certs: "{{ matrix_ma1sd_self_check_validate_certificates }}"
-  check_mode: no
+  check_mode: false
   register: result_ma1sd
   ignore_errors: true
 

roles/matrix-ma1sd/tasks/setup_install.yml

@@ -8,9 +8,9 @@
     owner: "{{ matrix_user_username }}"
     group: "{{ matrix_user_groupname }}"
   with_items:
-    - { path: "{{ matrix_ma1sd_config_path }}", when: true }
-    - { path: "{{ matrix_ma1sd_data_path }}", when: true }
-    - { path: "{{ matrix_ma1sd_docker_src_files_path }}", when: "{{ matrix_ma1sd_container_image_self_build }}"}
+    - {path: "{{ matrix_ma1sd_config_path }}", when: true}
+    - {path: "{{ matrix_ma1sd_data_path }}", when: true}
+    - {path: "{{ matrix_ma1sd_docker_src_files_path }}", when: "{{ matrix_ma1sd_container_image_self_build }}"}
   when: "item.when|bool"
 
 - import_tasks: "{{ role_path }}/tasks/migrate_mxisd.yml"
@@ -54,52 +54,52 @@
   when: "not matrix_ma1sd_container_image_self_build|bool"
 
 - block:
-  - name: Ensure gradle is installed for self-building (Debian)
-    apt:
-      name:
-        - gradle
-      state: present
-      update_cache: yes
-    when: (ansible_os_family == 'Debian')
+    - name: Ensure gradle is installed for self-building (Debian)
+      apt:
+        name:
+          - gradle
+        state: present
+        update_cache: true
+      when: (ansible_os_family == 'Debian')
 
-  - name: Ensure gradle is installed for self-building (CentOS)
-    fail:
-      msg: "Installing gradle on CentOS is currently not supported, so self-building ma1sd cannot happen at this time"
-    when: ansible_distribution == 'CentOS'
+    - name: Ensure gradle is installed for self-building (CentOS)
+      fail:
+        msg: "Installing gradle on CentOS is currently not supported, so self-building ma1sd cannot happen at this time"
+      when: ansible_distribution == 'CentOS'
 
-  - name: Ensure gradle is installed for self-building (Archlinux)
-    pacman:
-      name:
-        - gradle
-      state: latest
-      update_cache: yes
-    when: ansible_distribution == 'Archlinux'
+    - name: Ensure gradle is installed for self-building (Archlinux)
+      pacman:
+        name:
+          - gradle
+        state: latest
+        update_cache: true
+      when: ansible_distribution == 'Archlinux'
 
-  - name: Ensure ma1sd repository is present on self-build
-    git:
-      repo: "{{ matrix_ma1sd_container_image_self_build_repo }}"
-      dest: "{{ matrix_ma1sd_docker_src_files_path }}"
-      version: "{{ matrix_ma1sd_container_image_self_build_branch }}"
-      force: "yes"
-    register: matrix_ma1sd_git_pull_results
+    - name: Ensure ma1sd repository is present on self-build
+      git:
+        repo: "{{ matrix_ma1sd_container_image_self_build_repo }}"
+        dest: "{{ matrix_ma1sd_docker_src_files_path }}"
+        version: "{{ matrix_ma1sd_container_image_self_build_branch }}"
+        force: "yes"
+      register: matrix_ma1sd_git_pull_results
 
-  - name: Ensure ma1sd Docker image is built
-    shell: "DOCKER_BUILDKIT=1 ./gradlew dockerBuild"
-    args:
-      chdir: "{{ matrix_ma1sd_docker_src_files_path }}"
+    - name: Ensure ma1sd Docker image is built
+      shell: "DOCKER_BUILDKIT=1 ./gradlew dockerBuild"
+      args:
+        chdir: "{{ matrix_ma1sd_docker_src_files_path }}"
 
-  - name: Ensure ma1sd Docker image is tagged correctly
-    docker_image:
-      # The build script always tags the image with 2 tags:
-      # - based on the branch/version: e.g. `ma1uta/ma1sd:2.4.0` (when on `2.4.0`)
-      #   or `ma1uta/ma1sd:2.4.0-19-ga71d32b` (when on a given commit for a pre-release)
-      # - generic one: `ma1uta/ma1sd:latest-dev`
-      #
-      # It's hard to predict the first one, so we'll use the latter.
-      name: "ma1uta/ma1sd:latest-dev"
-      repository: "{{ matrix_ma1sd_docker_image }}"
-      force_tag: yes
-      source: local
+    - name: Ensure ma1sd Docker image is tagged correctly
+      docker_image:
+        # The build script always tags the image with 2 tags:
+        # - based on the branch/version: e.g. `ma1uta/ma1sd:2.4.0` (when on `2.4.0`)
+        #   or `ma1uta/ma1sd:2.4.0-19-ga71d32b` (when on a given commit for a pre-release)
+        # - generic one: `ma1uta/ma1sd:latest-dev`
+        #
+        # It's hard to predict the first one, so we'll use the latter.
+        name: "ma1uta/ma1sd:latest-dev"
+        repository: "{{ matrix_ma1sd_docker_image }}"
+        force_tag: true
+        source: local
   when: "matrix_ma1sd_container_image_self_build|bool"
 
 - name: Ensure ma1sd config installed
@@ -157,7 +157,7 @@
 
 - name: Ensure systemd reloaded after matrix-ma1sd.service installation
   service:
-    daemon_reload: yes
+    daemon_reload: true
   when: "matrix_ma1sd_systemd_service_result.changed|bool"
 
 - name: Ensure matrix-ma1sd.service restarted, if necessary

roles/matrix-ma1sd/tasks/setup_uninstall.yml

@@ -9,8 +9,8 @@
   service:
     name: matrix-ma1sd
     state: stopped
-    enabled: no
-    daemon_reload: yes
+    enabled: false
+    daemon_reload: true
   register: stopping_result
   when: "matrix_ma1sd_service_stat.stat.exists|bool"
 
@@ -22,7 +22,7 @@
 
 - name: Ensure systemd reloaded after matrix-ma1sd.service removal
   service:
-    daemon_reload: yes
+    daemon_reload: true
   when: "matrix_ma1sd_service_stat.stat.exists|bool"
 
 - name: Ensure Matrix ma1sd paths don't exist