finallycoffee/matrix-docker-ansible-deploy
finallycoffee/matrix-docker-ansible-deploy
5
1
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix import-postgres/run-postgres-vacuum failures being suppressed

Browse Source 
We were only reporting failures for when the async task didn't finish.
We also need to report a failure for when the task finished, but
returned a non-zero exit code.
This commit is contained in:
Slavi Pantaleev 2022-11-01 14:57:29 +02:00
parent 17caa13a71
commit 9fb21b89a8
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
roles/matrix-postgres/tasks/import_postgres.yml
View File

@ -108,5 +108,5 @@
async: "{{ postgres_import_wait_time }}" async: "{{ postgres_import_wait_time }}"
poll: 10 poll: 10
register: matrix_postgres_import_postgres_command_result register: matrix_postgres_import_postgres_command_result
failed_when: not matrix_postgres_import_postgres_command_result.finished failed_when: not matrix_postgres_import_postgres_command_result.finished or matrix_postgres_import_postgres_command_result.rc != 0
changed_when: matrix_postgres_import_postgres_command_result.finished and matrix_postgres_import_postgres_command_result.rc == 0 changed_when: matrix_postgres_import_postgres_command_result.finished and matrix_postgres_import_postgres_command_result.rc == 0

2
roles/matrix-postgres/tasks/run_vacuum.yml
View File

@ -79,7 +79,7 @@
async: "{{ postgres_vacuum_wait_time }}" async: "{{ postgres_vacuum_wait_time }}"
poll: 10 poll: 10
register: matrix_postgres_synapse_vacuum_result register: matrix_postgres_synapse_vacuum_result
failed_when: not matrix_postgres_synapse_vacuum_result.finished failed_when: not matrix_postgres_synapse_vacuum_result.finished or matrix_postgres_synapse_vacuum_result.rc != 0
changed_when: matrix_postgres_synapse_vacuum_result.finished and matrix_postgres_synapse_vacuum_result.rc == 0 changed_when: matrix_postgres_synapse_vacuum_result.finished and matrix_postgres_synapse_vacuum_result.rc == 0
# Intentionally show the results # Intentionally show the results

2
roles/matrix-synapse/tasks/rust-synapse-compress-state/compress_room.yml
View File

@ -21,7 +21,7 @@
async: "{{ matrix_synapse_rust_synapse_compress_state_compress_room_time }}" async: "{{ matrix_synapse_rust_synapse_compress_state_compress_room_time }}"
poll: 10 poll: 10
register: matrix_synapse_rust_synapse_compress_state_compress_room_command_result register: matrix_synapse_rust_synapse_compress_state_compress_room_command_result
failed_when: not matrix_synapse_rust_synapse_compress_state_compress_room_command_result.finished failed_when: not matrix_synapse_rust_synapse_compress_state_compress_room_command_result.finished or matrix_synapse_rust_synapse_compress_state_compress_room_command_result.rc != 0
changed_when: matrix_synapse_rust_synapse_compress_state_compress_room_command_result.finished and matrix_synapse_rust_synapse_compress_state_compress_room_command_result.rc == 0 changed_when: matrix_synapse_rust_synapse_compress_state_compress_room_command_result.finished and matrix_synapse_rust_synapse_compress_state_compress_room_command_result.rc == 0
- ansible.builtin.debug: - ansible.builtin.debug: