From a47ce70cd26a83148785d112e8b647377fe50300 Mon Sep 17 00:00:00 2001 From: Jim Myhrberg Date: Tue, 11 Oct 2022 00:43:22 +0100 Subject: [PATCH] fix(goofys): fix synapse systemd unit file to correctly require goofys On Debian 10 (buster) at least, while the Synapse systemd service unit was referring to Goofys as "matrix-goofys" without a ".service" suffix, systemd was ignoring the goofys dependency, starting Synapse before Goofys. All other dependant units which work are using the ".service" suffix. This generally leads to the mount path goofys using having been populated by Synapse before Goofys starts, causing it to fail due to the mount target not being empty. The fix seems to be to ensure that the Synapse service unit refers to Goofys as "matrix-goofys.service". This change causes the following two lines in "/etc/systemd/system/matrix-synapse.service": Requires=matrix-goofys After=matrix-goofys To be changed to: Requires=matrix-goofys.service After=matrix-goofys.service --- group_vars/matrix_servers | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/group_vars/matrix_servers b/group_vars/matrix_servers index cfccd3876..b055245bc 100755 --- a/group_vars/matrix_servers +++ b/group_vars/matrix_servers @@ -2364,7 +2364,7 @@ matrix_synapse_systemd_required_services_list: | + (['matrix-postgres.service'] if matrix_postgres_enabled else []) + - (['matrix-goofys'] if matrix_s3_media_store_enabled else []) + (['matrix-goofys.service'] if matrix_s3_media_store_enabled else []) }} matrix_synapse_systemd_wanted_services_list: | @@ -2650,7 +2650,7 @@ matrix_dendrite_systemd_required_services_list: | + (['matrix-postgres.service'] if matrix_postgres_enabled else []) + - (['matrix-goofys'] if matrix_s3_media_store_enabled else []) + (['matrix-goofys.service'] if matrix_s3_media_store_enabled else []) }} matrix_dendrite_systemd_wanted_services_list: |