Fix --tags=start regression

Related to #425 (Github Pull Request)

roles/matrix-common-after/tasks/start.yml

@@ -28,42 +28,37 @@
   delegate_to: 127.0.0.1
   become: false
 
-- name: Populate service facts
+- block:
-  service_facts:
+  - name: Populate service facts
-  when: ansible_distribution != 'Archlinux'
+    service_facts:
 
-- name: Fail if service isn't detected to be running
+  - name: Fail if service isn't detected to be running
-  fail:
+    fail:
-    msg: >-
+      msg: >-
-      {{ item }} was not detected to be running.
+        {{ item }} was not detected to be running.
-      It's possible that there's a configuration problem or another service on your server interferes with it (uses the same ports, etc.).
+        It's possible that there's a configuration problem or another service on your server interferes with it (uses the same ports, etc.).
-      Try running `systemctl status {{ item }}` and `journalctl -fu {{ item }}` on the server to investigate.
+        Try running `systemctl status {{ item }}` and `journalctl -fu {{ item }}` on the server to investigate.
-  with_items: "{{ matrix_systemd_services_list }}"
+    with_items: "{{ matrix_systemd_services_list }}"
-  when:
+    when:
-    - "ansible_facts.services[item + '.service']|default(none) is none or ansible_facts.services[item + '.service'].state != 'running'"
+      - "ansible_facts.services[item + '.service']|default(none) is none or ansible_facts.services[item + '.service'].state != 'running'"
-    - ansible_distribution != 'Archlinux'
+  when: " ansible_distribution != 'Archlinux'"
 
-# Currently there is a bug in ansible that renders is incompatible with systemd.
+- block:
-# service_facts is not collecting the data successfully.
+  # Currently there is a bug in ansible that renders is incompatible with systemd.
-# Therefore iterating here manually
+  # service_facts is not collecting the data successfully.
-- name: Fetch systemd information
+  # Therefore iterating here manually
-  systemd:
+  - name: Fetch systemd information
-    name: "{{ item }}"
+    systemd:
-  register: systemdstatus
+      name: "{{ item }}"
-  with_items: "{{ matrix_systemd_services_list }}"
+    register: systemdstatus
-  when:
+    with_items: "{{ matrix_systemd_services_list }}"
-    - ansible_distribution == 'Archlinux'
 
-- name: Fail if service isn't detected to be running
+  - name: Fail if service isn't detected to be running
-  fail:
+    fail:
-    msg: >-
+      msg: >-
-      {{ item.item }} was not detected to be running.
+        {{ item.item }} was not detected to be running.
-      It's possible that there's a configuration problem or another service on your server interferes with it (uses the same ports, etc.).
+        It's possible that there's a configuration problem or another service on your server interferes with it (uses the same ports, etc.).
-      Try running `systemctl status {{ item.item }}` and `journalctl -fu {{ item.item }}` on the server to investigate.
+        Try running `systemctl status {{ item.item }}` and `journalctl -fu {{ item.item }}` on the server to investigate.
-  with_items: "{{ systemdstatus.results }}"
+    with_items: "{{ systemdstatus.results }}"
-  loop_control:
+    when: "item.status['ActiveState'] != 'active'"
-    label: "{{ item.name }}"
+  when: "ansible_distribution == 'Archlinux'"
-  when:
-    #- "ansible_facts.services[item + '.service']|default(none) is none or ansible_facts.services[item + '.service'].state != 'running'"
-    - "item.status['ActiveState'] != 'active'"
-    - "ansible_distribution == 'Archlinux'"