From cf452fdf0a1ece84ae4c54e6a73a8618114c5132 Mon Sep 17 00:00:00 2001
From: Marcel Partap <mpartap@gmx.net>
Date: Sun, 19 Apr 2020 10:16:01 +0200
Subject: [PATCH] Fix corner-cases found through testing (aka ansible is nuts)

---
 roles/matrix-synapse/tasks/workers/setup.yml         |  1 +
 roles/matrix-synapse/tasks/workers/setup_install.yml |  3 ++-
 .../matrix-synapse/tasks/workers/setup_uninstall.yml | 12 ++++++++----
 3 files changed, 11 insertions(+), 5 deletions(-)

diff --git a/roles/matrix-synapse/tasks/workers/setup.yml b/roles/matrix-synapse/tasks/workers/setup.yml
index faf2899e2..4951ac2d7 100644
--- a/roles/matrix-synapse/tasks/workers/setup.yml
+++ b/roles/matrix-synapse/tasks/workers/setup.yml
@@ -1,4 +1,5 @@
 ---
+# a negative when condition will not actually prevent ansible from executing loops in imported tasks!
 
 - import_tasks: "{{ role_path }}/tasks/workers/setup_install.yml"
   when: "matrix_synapse_enabled|bool and matrix_synapse_workers_enabled|bool"
diff --git a/roles/matrix-synapse/tasks/workers/setup_install.yml b/roles/matrix-synapse/tasks/workers/setup_install.yml
index 1f23d0c5a..0031c236c 100644
--- a/roles/matrix-synapse/tasks/workers/setup_install.yml
+++ b/roles/matrix-synapse/tasks/workers/setup_install.yml
@@ -12,8 +12,9 @@
     path: "{{ item.root + '/' + item.path }}"
     state: absent
   when:
+    - matrix_synapse_workers_enabled|bool
     - item.state == 'link'
-    - item.path is match('matrix-synapse-worker@*.service')
+    - item.path is match('matrix-synapse-worker@.*\\.service')
   with_filetree:
     - "{{ matrix_systemd_path }}/matrix-synapse.service.wants"
 
diff --git a/roles/matrix-synapse/tasks/workers/setup_uninstall.yml b/roles/matrix-synapse/tasks/workers/setup_uninstall.yml
index 864308794..d1e7e3b56 100644
--- a/roles/matrix-synapse/tasks/workers/setup_uninstall.yml
+++ b/roles/matrix-synapse/tasks/workers/setup_uninstall.yml
@@ -1,10 +1,13 @@
 ---
 
-- name: Ensure individual worker services are stopped
+- name: Populate service facts
+  service_facts:
+
+- name: Ensure any worker services are stopped
   service:
-    name: "matrix-synapse-worker@{{ item.worker }}:{{ item.port }}.service"
+    name: "{{ item.key }}"
     state: stopped
-  with_items: "{{ matrix_synapse_workers_enabled_list }}"
+  with_dict: "{{ ansible_facts.services|default({})|dict2items|selectattr('key', 'match', 'matrix-synapse-worker@.+\\.service')|list|items2dict }}"
 
 # As we cannot know the ports of workers removed from the enabled_list..
 # => .. just kill them all (FIXME?)
@@ -13,8 +16,9 @@
     path: "{{ item.root + '/' + item.path }}"
     state: absent
   when:
+    - not matrix_synapse_workers_enabled|bool
     - item.state == 'link'
-    - item.path is match('matrix-synapse-worker@*.service')
+    - item.path is match('matrix-synapse-worker@.*\\.service')
   with_filetree:
     - "{{ matrix_systemd_path }}/matrix-synapse.service.wants"