More ansible-lint fixes

roles/matrix-synapse/tasks/register_user.yml

@@ -29,3 +29,5 @@
 
 - name: Register user
   ansible.builtin.command: "{{ matrix_local_bin_path }}/matrix-synapse-register-user {{ username|quote }} {{ password|quote }} {{ '1' if admin == 'yes' else '0' }}"
+  register: matrix_synapse_register_user_result
+  changed_when: matrix_synapse_register_user_result.rc == 0

roles/matrix-synapse/tasks/rust-synapse-compress-state/compress_room.yml

@@ -21,6 +21,7 @@
   async: "{{ matrix_synapse_rust_synapse_compress_state_compress_room_time }}"
   poll: 10
   register: matrix_synapse_rust_synapse_compress_state_compress_room_command_result
+  changed_when: matrix_synapse_rust_synapse_compress_state_compress_room_command_result.rc == 0
 
 - ansible.builtin.debug: var="matrix_synapse_rust_synapse_compress_state_compress_room_command_result"
 
@@ -43,6 +44,7 @@
   async: "{{ matrix_synapse_rust_synapse_compress_state_psql_import_time }}"
   poll: 10
   register: matrix_synapse_rust_synapse_compress_state_psql_import_command_result
+  changed_when: matrix_synapse_rust_synapse_compress_state_psql_import_command_result.rc == 0
 
 - name: Clean up
   ansible.builtin.file:

roles/matrix-synapse/tasks/rust-synapse-compress-state/main.yml

@@ -70,6 +70,7 @@
   async: "{{ matrix_synapse_rust_synapse_compress_state_find_rooms_command_wait_time }}"
   poll: 10
   register: matrix_synapse_rust_synapse_compress_state_find_rooms_command_result
+  changed_when: false
 
 # We expect the output to be like this:
 #

roles/matrix-synapse/tasks/synapse/setup_install.yml

@@ -32,6 +32,7 @@
     - name: Check if Synapse Docker image exists
       ansible.builtin.command: "{{ matrix_host_command_docker }} images --quiet --filter 'reference={{ matrix_synapse_docker_image }}'"
       register: matrix_synapse_docker_image_check_result
+      changed_when: false
 
     # Invoking the `docker build` command here, instead of calling the `docker_image` Ansible module,
     # because the latter does not support BuildKit.

roles/matrix-synapse/tasks/synapse/workers/init.yml

@@ -12,7 +12,7 @@
       port: "{{ matrix_synapse_workers_generic_workers_port_range_start + item }}"
       metrics_port: "{{ matrix_synapse_workers_generic_workers_metrics_range_start + item }}"
   register: "matrix_synapse_workers_list_results_generic_workers"
-  loop: "{{ range(0, matrix_synapse_workers_generic_workers_count|int) | list }}"
+  loop: "{{ range(0, matrix_synapse_workers_generic_workers_count | int) | list }}"
 
 - name: Build federation sender workers
   ansible.builtin.set_fact:
@@ -22,7 +22,7 @@
       port: 0
       metrics_port: "{{ matrix_synapse_workers_federation_sender_workers_metrics_range_start + item }}"
   register: "matrix_synapse_workers_list_results_federation_sender_workers"
-  loop: "{{ range(0, matrix_synapse_workers_federation_sender_workers_count|int) | list }}"
+  loop: "{{ range(0, matrix_synapse_workers_federation_sender_workers_count | int) | list }}"
 
 # This type of worker can only have a count of 1, at most
 - name: Build pusher workers
@@ -33,7 +33,7 @@
       port: 0
       metrics_port: "{{ matrix_synapse_workers_pusher_workers_metrics_range_start + item }}"
   register: "matrix_synapse_workers_list_results_pusher_workers"
-  loop: "{{ range(0, matrix_synapse_workers_pusher_workers_count|int) | list }}"
+  loop: "{{ range(0, matrix_synapse_workers_pusher_workers_count | int) | list }}"
 
 # This type of worker can only have a count of 1, at most
 - name: Build appservice workers
@@ -44,7 +44,7 @@
       port: 0
       metrics_port: "{{ matrix_synapse_workers_appservice_workers_metrics_range_start + item }}"
   register: "matrix_synapse_workers_list_results_appservice_workers"
-  loop: "{{ range(0, matrix_synapse_workers_appservice_workers_count|int) | list }}"
+  loop: "{{ range(0, matrix_synapse_workers_appservice_workers_count | int) | list }}"
 
 - name: Build media_repository workers
   ansible.builtin.set_fact:
@@ -54,7 +54,7 @@
       port: "{{ matrix_synapse_workers_media_repository_workers_port_range_start + item }}"
       metrics_port: "{{ matrix_synapse_workers_media_repository_workers_metrics_range_start + item }}"
   register: "matrix_synapse_workers_list_results_media_repository_workers"
-  loop: "{{ range(0, matrix_synapse_workers_media_repository_workers_count|int) | list }}"
+  loop: "{{ range(0, matrix_synapse_workers_media_repository_workers_count | int) | list }}"
 
 - name: Build frontend_proxy workers
   ansible.builtin.set_fact:
@@ -64,7 +64,7 @@
       port: "{{ matrix_synapse_workers_frontend_proxy_workers_port_range_start + item }}"
       metrics_port: "{{ matrix_synapse_workers_frontend_proxy_workers_metrics_range_start + item }}"
   register: "matrix_synapse_workers_list_results_frontend_proxy_workers"
-  loop: "{{ range(0, matrix_synapse_workers_frontend_proxy_workers_count|int) | list }}"
+  loop: "{{ range(0, matrix_synapse_workers_frontend_proxy_workers_count | int) | list }}"
 
 - ansible.builtin.set_fact:
     matrix_synapse_dynamic_workers_list: "{{ matrix_synapse_dynamic_workers_list | default([]) + [item.ansible_facts.worker] }}"

roles/matrix-synapse/tasks/synapse/workers/setup_uninstall.yml

@@ -7,7 +7,7 @@
   ansible.builtin.service:
     name: "{{ item.key }}"
     state: stopped
-  with_dict: "{{ ansible_facts.services | default({})|dict2items|selectattr('key', 'match', 'matrix-synapse-worker-.+\\.service')|list|items2dict }}"
+  with_dict: "{{ ansible_facts.services | default({}) | dict2items | selectattr('key', 'match', 'matrix-synapse-worker-.+\\.service') | list | items2dict }}"
   when: "item.value['status'] != 'not-found'"  # see https://github.com/spantaleev/matrix-docker-ansible-deploy/issues/1461
 
 - name: Find worker configs to be cleaned

roles/matrix-synapse/tasks/update_user_password.yml

@@ -38,6 +38,9 @@
 - name: Generate password hash
   ansible.builtin.shell: "{{ matrix_host_command_docker }} exec matrix-synapse /usr/local/bin/hash_password -c /data/homeserver.yaml -p {{ password|quote }}"
   register: password_hash
+  changed_when: false
 
 - name: Update user password hash
   ansible.builtin.command: "{{ matrix_local_bin_path }}/matrix-postgres-update-user-password-hash {{ username|quote }} {{ password_hash.stdout|quote }}"
+  register: matrix_synapse_update_user_password_result
+  changed_when: matrix_synapse_update_user_password_result.rc == 0