finallycoffee/matrix-docker-ansible-deploy
5
1
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Report async task failures better

Browse Source 
We were previously trying to reach into `.rc`,
but there's no such thing if `async_result.finished == 0`.

Fixes https://github.com/spantaleev/matrix-docker-ansible-deploy/issues/2153
This commit is contained in:
Slavi Pantaleev
2022-10-06 10:03:16 +03:00
parent ff2afacc66
commit d1b5681ba0
4 changed files with 9 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
roles/matrix-postgres/tasks/import_postgres.yml
View File

@@ -108,4 +108,5 @@
async: "{{ postgres_import_wait_time }}" async: "{{ postgres_import_wait_time }}"
poll: 10 poll: 10
register: matrix_postgres_import_postgres_command_result register: matrix_postgres_import_postgres_command_result
changed_when: matrix_postgres_import_postgres_command_result.rc == 0 failed_when: not matrix_postgres_import_postgres_command_result.async_result.finished
changed_when: matrix_postgres_import_postgres_command_result.async_result.finished and matrix_postgres_import_postgres_command_result.rc == 0

3
roles/matrix-postgres/tasks/run_vacuum.yml
View File

@@ -78,7 +78,8 @@
async: "{{ postgres_vacuum_wait_time }}" async: "{{ postgres_vacuum_wait_time }}"
poll: 10 poll: 10
register: matrix_postgres_synapse_vacuum_result register: matrix_postgres_synapse_vacuum_result
changed_when: matrix_postgres_synapse_vacuum_result.rc == 0 failed_when: not matrix_postgres_synapse_vacuum_result.async_result.finished
changed_when: matrix_postgres_synapse_vacuum_result.async_result.finished and matrix_postgres_synapse_vacuum_result.rc == 0
# Intentionally show the results # Intentionally show the results
- ansible.builtin.debug: var="matrix_postgres_synapse_vacuum_result" - ansible.builtin.debug: var="matrix_postgres_synapse_vacuum_result"

6
roles/matrix-synapse/tasks/rust-synapse-compress-state/compress_room.yml
View File

@@ -21,7 +21,8 @@
async: "{{ matrix_synapse_rust_synapse_compress_state_compress_room_time }}" async: "{{ matrix_synapse_rust_synapse_compress_state_compress_room_time }}"
poll: 10 poll: 10
register: matrix_synapse_rust_synapse_compress_state_compress_room_command_result register: matrix_synapse_rust_synapse_compress_state_compress_room_command_result
changed_when: matrix_synapse_rust_synapse_compress_state_compress_room_command_result.rc == 0 failed_when: not matrix_synapse_rust_synapse_compress_state_compress_room_command_result.async_result.finished
changed_when: matrix_synapse_rust_synapse_compress_state_compress_room_command_result.async_result.finished and matrix_synapse_rust_synapse_compress_state_compress_room_command_result.rc == 0
- ansible.builtin.debug: var="matrix_synapse_rust_synapse_compress_state_compress_room_command_result" - ansible.builtin.debug: var="matrix_synapse_rust_synapse_compress_state_compress_room_command_result"
@@ -44,7 +45,8 @@
async: "{{ matrix_synapse_rust_synapse_compress_state_psql_import_time }}" async: "{{ matrix_synapse_rust_synapse_compress_state_psql_import_time }}"
poll: 10 poll: 10
register: matrix_synapse_rust_synapse_compress_state_psql_import_command_result register: matrix_synapse_rust_synapse_compress_state_psql_import_command_result
changed_when: matrix_synapse_rust_synapse_compress_state_psql_import_command_result.rc == 0 failed_when: not matrix_synapse_rust_synapse_compress_state_psql_import_command_result.async_result.finished
changed_when: matrix_synapse_rust_synapse_compress_state_psql_import_command_result.async_result.finished and matrix_synapse_rust_synapse_compress_state_psql_import_command_result.rc == 0
- name: Clean up - name: Clean up
ansible.builtin.file: ansible.builtin.file:

1
roles/matrix-synapse/tasks/rust-synapse-compress-state/main.yml
View File

@@ -70,6 +70,7 @@
async: "{{ matrix_synapse_rust_synapse_compress_state_find_rooms_command_wait_time }}" async: "{{ matrix_synapse_rust_synapse_compress_state_find_rooms_command_wait_time }}"
poll: 10 poll: 10
register: matrix_synapse_rust_synapse_compress_state_find_rooms_command_result register: matrix_synapse_rust_synapse_compress_state_find_rooms_command_result
failed_when: not matrix_synapse_rust_synapse_compress_state_find_rooms_command_result.async_result.finished
changed_when: false changed_when: false
# We expect the output to be like this: # We expect the output to be like this: