Fix all 300+ ansible-lint-reported errors

roles/custom/matrix-bridge-mx-puppet-twitter/tasks/main.yml

@@ -1,29 +1,29 @@
 ---
 
-- block:
-    - when: matrix_mx_puppet_twitter_enabled | bool
-      ansible.builtin.include_tasks: "{{ role_path }}/tasks/inject_into_nginx_proxy.yml"
-  tags:
+- tags:
     - setup-all
     - setup-nginx-proxy
     - install-all
     - install-nginx-proxy
+  block:
+    - when: matrix_mx_puppet_twitter_enabled | bool
+      ansible.builtin.include_tasks: "{{ role_path }}/tasks/inject_into_nginx_proxy.yml"
 
-- block:
+- tags:
+    - setup-all
+    - setup-mx-puppet-twitter
+    - install-all
+    - install-mx-puppet-twitter
+  block:
     - when: matrix_mx_puppet_twitter_enabled | bool
       ansible.builtin.include_tasks: "{{ role_path }}/tasks/validate_config.yml"
 
     - when: matrix_mx_puppet_twitter_enabled | bool
       ansible.builtin.include_tasks: "{{ role_path }}/tasks/setup_install.yml"
-  tags:
+
+- tags:
     - setup-all
     - setup-mx-puppet-twitter
-    - install-all
-    - install-mx-puppet-twitter
-
-- block:
+  block:
     - when: not matrix_mx_puppet_twitter_enabled | bool
       ansible.builtin.include_tasks: "{{ role_path }}/tasks/setup_uninstall.yml"
-  tags:
-    - setup-all
-    - setup-mx-puppet-twitter

roles/custom/matrix-bridge-mx-puppet-twitter/tasks/setup_install.yml

@@ -29,7 +29,10 @@
   when: "matrix_mx_puppet_twitter_stat_database.stat.exists"
 
 - name: (Data relocation) Move mx-puppet-twitter database file to ./data directory
-  ansible.builtin.command: "mv {{ matrix_mx_puppet_twitter_base_path }}/database.db {{ matrix_mx_puppet_twitter_data_path }}/database.db"
+  ansible.builtin.command:
+    cmd: "mv {{ matrix_mx_puppet_twitter_base_path }}/database.db {{ matrix_mx_puppet_twitter_data_path }}/database.db"
+    creates: "{{ matrix_mx_puppet_twitter_data_path }}/database.db"
+    removes: "{{ matrix_mx_puppet_twitter_base_path }}/database.db"
   when: "matrix_mx_puppet_twitter_stat_database.stat.exists"
 
 - ansible.builtin.set_fact: