More ansible-lint fixes

roles/matrix-bridge-mx-puppet-discord/defaults/main.yml

@@ -88,11 +88,11 @@ matrix_mx_puppet_discord_configuration_extension_yaml: |
   # If you need something more special, you can take full control by
   # completely redefining `matrix_mx_puppet_discord_configuration_yaml`.
 
-matrix_mx_puppet_discord_configuration_extension: "{{ matrix_mx_puppet_discord_configuration_extension_yaml|from_yaml if matrix_mx_puppet_discord_configuration_extension_yaml|from_yaml is mapping else {} }}"
+matrix_mx_puppet_discord_configuration_extension: "{{ matrix_mx_puppet_discord_configuration_extension_yaml | from_yaml if matrix_mx_puppet_discord_configuration_extension_yaml | from_yaml is mapping else {} }}"
 
 # Holds the final configuration (a combination of the default and its extension).
 # You most likely don't need to touch this variable. Instead, see `matrix_mx_puppet_discord_configuration_yaml`.
-matrix_mx_puppet_discord_configuration: "{{ matrix_mx_puppet_discord_configuration_yaml|from_yaml|combine(matrix_mx_puppet_discord_configuration_extension, recursive=True) }}"
+matrix_mx_puppet_discord_configuration: "{{ matrix_mx_puppet_discord_configuration_yaml | from_yaml|combine(matrix_mx_puppet_discord_configuration_extension, recursive=True) }}"
 
 matrix_mx_puppet_discord_registration_yaml: |
   as_token: "{{ matrix_mx_puppet_discord_appservice_token }}"
@@ -112,4 +112,4 @@ matrix_mx_puppet_discord_registration_yaml: |
   url: {{ matrix_mx_puppet_discord_appservice_address }}
   de.sorunome.msc2409.push_ephemeral: true
 
-matrix_mx_puppet_discord_registration: "{{ matrix_mx_puppet_discord_registration_yaml|from_yaml }}"
+matrix_mx_puppet_discord_registration: "{{ matrix_mx_puppet_discord_registration_yaml | from_yaml }}"

roles/matrix-bridge-mx-puppet-discord/tasks/init.yml

@@ -8,21 +8,21 @@
 
 - ansible.builtin.set_fact:
     matrix_systemd_services_list: "{{ matrix_systemd_services_list + ['matrix-mx-puppet-discord.service'] }}"
-  when: matrix_mx_puppet_discord_enabled|bool
+  when: matrix_mx_puppet_discord_enabled | bool
 
 # If the matrix-synapse role is not used, these variables may not exist.
 - ansible.builtin.set_fact:
     matrix_synapse_container_extra_arguments: >
       {{
-        matrix_synapse_container_extra_arguments|default([])
+        matrix_synapse_container_extra_arguments | default([])
         +
         ["--mount type=bind,src={{ matrix_mx_puppet_discord_config_path }}/registration.yaml,dst=/matrix-mx-puppet-discord-registration.yaml,ro"]
       }}
 
     matrix_synapse_app_service_config_files: >
       {{
-        matrix_synapse_app_service_config_files|default([])
+        matrix_synapse_app_service_config_files | default([])
         +
         ["/matrix-mx-puppet-discord-registration.yaml"]
       }}
-  when: matrix_mx_puppet_discord_enabled|bool
+  when: matrix_mx_puppet_discord_enabled | bool

roles/matrix-bridge-mx-puppet-discord/tasks/main.yml

@@ -1,23 +1,23 @@
 ---
 
-- import_tasks: "{{ role_path }}/tasks/init.yml"
+- ansible.builtin.import_tasks: "{{ role_path }}/tasks/init.yml"
   tags:
     - always
 
-- import_tasks: "{{ role_path }}/tasks/validate_config.yml"
-  when: "run_setup|bool and matrix_mx_puppet_discord_enabled|bool"
+- ansible.builtin.import_tasks: "{{ role_path }}/tasks/validate_config.yml"
+  when: "run_setup | bool and matrix_mx_puppet_discord_enabled | bool"
   tags:
     - setup-all
     - setup-mx-puppet-discord
 
-- import_tasks: "{{ role_path }}/tasks/setup_install.yml"
-  when: "run_setup|bool and matrix_mx_puppet_discord_enabled|bool"
+- ansible.builtin.import_tasks: "{{ role_path }}/tasks/setup_install.yml"
+  when: "run_setup | bool and matrix_mx_puppet_discord_enabled | bool"
   tags:
     - setup-all
     - setup-mx-puppet-discord
 
-- import_tasks: "{{ role_path }}/tasks/setup_uninstall.yml"
-  when: "run_setup|bool and not matrix_mx_puppet_discord_enabled|bool"
+- ansible.builtin.import_tasks: "{{ role_path }}/tasks/setup_uninstall.yml"
+  when: "run_setup | bool and not matrix_mx_puppet_discord_enabled | bool"
   tags:
     - setup-all
     - setup-mx-puppet-discord

roles/matrix-bridge-mx-puppet-discord/tasks/setup_install.yml

@@ -6,7 +6,7 @@
   ansible.builtin.fail:
     msg: >-
       The matrix-bridge-mx-puppet-discord role needs to execute before the matrix-synapse role.
-  when: "matrix_synapse_role_executed|default(False)"
+  when: "matrix_synapse_role_executed | default(False)"
 
 - name: Ensure MX Puppet Discord paths exist
   ansible.builtin.file:
@@ -20,10 +20,10 @@
     - {path: "{{ matrix_mx_puppet_discord_config_path }}", when: true}
     - {path: "{{ matrix_mx_puppet_discord_data_path }}", when: true}
     - {path: "{{ matrix_mx_puppet_discord_docker_src_files_path }}", when: "{{ matrix_mx_puppet_discord_container_image_self_build }}"}
-  when: matrix_mx_puppet_discord_enabled|bool and item.when|bool
+  when: matrix_mx_puppet_discord_enabled | bool and item.when | bool
 
 - name: Check if an old database file already exists
-  stat:
+  ansible.builtin.stat:
     path: "{{ matrix_mx_puppet_discord_base_path }}/database.db"
   register: matrix_mx_puppet_discord_stat_database
 
@@ -44,7 +44,7 @@
 
 - block:
     - name: Check if an SQLite database already exists
-      stat:
+      ansible.builtin.stat:
         path: "{{ matrix_mx_puppet_discord_sqlite_database_path_local }}"
       register: matrix_mx_puppet_discord_sqlite_database_path_local_stat_result
 
@@ -53,16 +53,16 @@
             matrix_postgres_db_migration_request:
               src: "{{ matrix_mx_puppet_discord_sqlite_database_path_local }}"
               dst: "{{ matrix_mx_puppet_discord_database_connection_string }}"
-              caller: "{{ role_path|basename }}"
+              caller: "{{ role_path | basename }}"
               engine_variable_name: 'matrix_mx_puppet_discord_database_engine'
               engine_old: 'sqlite'
               systemd_services_to_stop: ['matrix-mx-puppet-discord.service']
 
-        - import_tasks: "{{ role_path }}/../matrix-postgres/tasks/util/migrate_db_to_postgres.yml"
+        - ansible.builtin.import_tasks: "{{ role_path }}/../matrix-postgres/tasks/util/migrate_db_to_postgres.yml"
 
         - ansible.builtin.set_fact:
             matrix_mx_puppet_discord_requires_restart: true
-      when: "matrix_mx_puppet_discord_sqlite_database_path_local_stat_result.stat.exists|bool"
+      when: "matrix_mx_puppet_discord_sqlite_database_path_local_stat_result.stat.exists | bool"
   when: "matrix_mx_puppet_discord_database_engine == 'postgres'"
 
 - name: Ensure MX Puppet Discord image is pulled
@@ -71,7 +71,7 @@
     source: "{{ 'pull' if ansible_version.major > 2 or ansible_version.minor > 7 else omit }}"
     force_source: "{{ matrix_mx_puppet_discord_docker_image_force_pull if ansible_version.major > 2 or ansible_version.minor >= 8 else omit }}"
     force: "{{ omit if ansible_version.major > 2 or ansible_version.minor >= 8 else matrix_mx_puppet_discord_docker_image_force_pull }}"
-  when: matrix_mx_puppet_discord_enabled|bool and not matrix_mx_puppet_discord_container_image_self_build
+  when: matrix_mx_puppet_discord_enabled | bool and not matrix_mx_puppet_discord_container_image_self_build
   register: result
   retries: "{{ matrix_container_retries_count }}"
   delay: "{{ matrix_container_retries_delay }}"
@@ -86,7 +86,7 @@
   become: true
   become_user: "{{ matrix_user_username }}"
   register: matrix_mx_puppet_discord_git_pull_results
-  when: "matrix_mx_puppet_discord_enabled|bool and matrix_mx_puppet_discord_container_image_self_build"
+  when: "matrix_mx_puppet_discord_enabled | bool and matrix_mx_puppet_discord_container_image_self_build"
 
 - name: Ensure MX Puppet Discord Docker image is built
   docker_image:
@@ -98,11 +98,11 @@
       dockerfile: "{{ matrix_mx_puppet_discord_container_image_self_build_dockerfile_path }}"
       path: "{{ matrix_mx_puppet_discord_docker_src_files_path }}"
       pull: true
-  when: "matrix_mx_puppet_discord_enabled|bool and matrix_mx_puppet_discord_container_image_self_build|bool"
+  when: "matrix_mx_puppet_discord_enabled | bool and matrix_mx_puppet_discord_container_image_self_build | bool"
 
 - name: Ensure mx-puppet-discord config.yaml installed
   ansible.builtin.copy:
-    content: "{{ matrix_mx_puppet_discord_configuration|to_nice_yaml(indent=2, width=999999) }}"
+    content: "{{ matrix_mx_puppet_discord_configuration | to_nice_yaml(indent=2, width=999999) }}"
     dest: "{{ matrix_mx_puppet_discord_config_path }}/config.yaml"
     mode: 0644
     owner: "{{ matrix_user_username }}"
@@ -110,7 +110,7 @@
 
 - name: Ensure mx-puppet-discord discord-registration.yaml installed
   ansible.builtin.copy:
-    content: "{{ matrix_mx_puppet_discord_registration|to_nice_yaml(indent=2, width=999999) }}"
+    content: "{{ matrix_mx_puppet_discord_registration | to_nice_yaml(indent=2, width=999999) }}"
     dest: "{{ matrix_mx_puppet_discord_config_path }}/registration.yaml"
     mode: 0644
     owner: "{{ matrix_user_username }}"
@@ -132,4 +132,4 @@
   ansible.builtin.service:
     name: "matrix-mx-puppet-discord.service"
     state: restarted
-  when: "matrix_mx_puppet_discord_requires_restart|bool"
+  when: "matrix_mx_puppet_discord_requires_restart | bool"

roles/matrix-bridge-mx-puppet-discord/tasks/setup_uninstall.yml

@@ -1,7 +1,7 @@
 ---
 
 - name: Check existence of matrix-mx-puppet-discord service
-  stat:
+  ansible.builtin.stat:
     path: "/etc/systemd/system/matrix-mx-puppet-discord.service"
   register: matrix_mx_puppet_discord_service_stat