More ansible-lint fixes

roles/matrix-nginx-proxy/tasks/ssl/main.yml

@@ -29,8 +29,8 @@
 
 # Method specific tasks follow
 
-- import_tasks: tasks/ssl/setup_ssl_lets_encrypt.yml
+- ansible.builtin.import_tasks: tasks/ssl/setup_ssl_lets_encrypt.yml
 
-- import_tasks: tasks/ssl/setup_ssl_self_signed.yml
+- ansible.builtin.import_tasks: tasks/ssl/setup_ssl_self_signed.yml
 
-- import_tasks: tasks/ssl/setup_ssl_manually_managed.yml
+- ansible.builtin.import_tasks: tasks/ssl/setup_ssl_manually_managed.yml

roles/matrix-nginx-proxy/tasks/ssl/setup_ssl_lets_encrypt.yml

@@ -25,7 +25,7 @@
         force: "{{ omit if ansible_version.major > 2 or ansible_version.minor >= 8 else matrix_ssl_lets_encrypt_certbot_docker_image_force_pull }}"
 
     - name: Obtain Let's Encrypt certificates
-      include_tasks: "{{ role_path }}/tasks/ssl/setup_ssl_lets_encrypt_obtain_for_domain.yml"
+      ansible.builtin.include_tasks: "{{ role_path }}/tasks/ssl/setup_ssl_lets_encrypt_obtain_for_domain.yml"
       with_items: "{{ matrix_ssl_domains_to_obtain_certificates_for }}"
       loop_control:
         loop_var: domain_name
@@ -41,7 +41,7 @@
         src: "{{ role_path }}/templates/systemd/{{ item.name }}.j2"
         dest: "{{ matrix_systemd_path }}/{{ item.name }}"
         mode: 0644
-      when: "item.applicable|bool"
+      when: "item.applicable | bool"
       with_items: "{{ matrix_ssl_renewal_systemd_units_list }}"
   when: "matrix_ssl_retrieval_method == 'lets-encrypt'"
 
@@ -54,7 +54,7 @@
       ansible.builtin.file:
         path: "{{ matrix_systemd_path }}/{{ item.name }}"
         state: absent
-      when: "not item.applicable|bool"
+      when: "not item.applicable | bool"
       with_items: "{{ matrix_ssl_renewal_systemd_units_list }}"
 
     - name: Ensure Let's Encrypt SSL renewal script removed

roles/matrix-nginx-proxy/tasks/ssl/setup_ssl_lets_encrypt_obtain_for_domain.yml

@@ -6,7 +6,7 @@
     domain_name_certificate_path: "{{ matrix_ssl_config_dir_path }}/live/{{ domain_name }}/fullchain.pem"
 
 - name: Check if a certificate for the domain already exists
-  stat:
+  ansible.builtin.stat:
     path: "{{ domain_name_certificate_path }}"
   register: domain_name_certificate_path_stat
 
@@ -21,10 +21,10 @@
       register: matrix_ssl_pre_obtaining_required_service_start_result
 
     - name: Wait some time, so that the required service for obtaining can start
-      wait_for:
+      ansible.builtin.wait_for:
         timeout: "{{ matrix_ssl_pre_obtaining_required_service_start_wait_time_seconds }}"
-      when: "matrix_ssl_pre_obtaining_required_service_start_result.changed|bool"
-  when: "domain_name_needs_cert|bool and matrix_ssl_pre_obtaining_required_service_name != ''"
+      when: "matrix_ssl_pre_obtaining_required_service_start_result.changed | bool"
+  when: "domain_name_needs_cert | bool and matrix_ssl_pre_obtaining_required_service_name != ''"
 
 # This will fail if there is something running on port 80 (like matrix-nginx-proxy).
 # We suppress the error, as we'll try another method below.
@@ -51,7 +51,7 @@
     --agree-tos
     --email={{ matrix_ssl_lets_encrypt_support_email }}
     -d {{ domain_name }}
-  when: domain_name_needs_cert|bool
+  when: domain_name_needs_cert | bool
   register: result_certbot_direct
   ignore_errors: true
 

roles/matrix-nginx-proxy/tasks/ssl/setup_ssl_manually_managed.yml

@@ -1,7 +1,7 @@
 ---
 
 - name: Verify certificates
-  include_tasks: "{{ role_path }}/tasks/ssl/setup_ssl_manually_managed_verify_for_domain.yml"
+  ansible.builtin.include_tasks: "{{ role_path }}/tasks/ssl/setup_ssl_manually_managed_verify_for_domain.yml"
   with_items: "{{ matrix_ssl_domains_to_obtain_certificates_for }}"
   loop_control:
     loop_var: domain_name

roles/matrix-nginx-proxy/tasks/ssl/setup_ssl_manually_managed_verify_for_domain.yml

@@ -5,7 +5,7 @@
     matrix_ssl_certificate_verification_cert_key_path: "{{ matrix_ssl_config_dir_path }}/live/{{ domain_name }}/privkey.pem"
 
 - name: Check if SSL certificate file exists
-  stat:
+  ansible.builtin.stat:
     path: "{{ matrix_ssl_certificate_verification_cert_path }}"
   register: matrix_ssl_certificate_verification_cert_path_stat_result
 
@@ -14,7 +14,7 @@
   when: "not matrix_ssl_certificate_verification_cert_path_stat_result.stat.exists"
 
 - name: Check if SSL certificate key file exists
-  stat:
+  ansible.builtin.stat:
     path: "{{ matrix_ssl_certificate_verification_cert_key_path }}"
   register: matrix_ssl_certificate_verification_cert_key_path_stat_result
 

roles/matrix-nginx-proxy/tasks/ssl/setup_ssl_self_signed.yml

@@ -1,10 +1,10 @@
 ---
 
-- import_tasks: "{{ role_path }}/../matrix-base/tasks/util/ensure_openssl_installed.yml"
+- ansible.builtin.import_tasks: "{{ role_path }}/../matrix-base/tasks/util/ensure_openssl_installed.yml"
   when: "matrix_ssl_retrieval_method == 'self-signed'"
 
 - name: Generate self-signed certificates
-  include_tasks: "{{ role_path }}/tasks/ssl/setup_ssl_self_signed_obtain_for_domain.yml"
+  ansible.builtin.include_tasks: "{{ role_path }}/tasks/ssl/setup_ssl_self_signed_obtain_for_domain.yml"
   with_items: "{{ matrix_ssl_domains_to_obtain_certificates_for }}"
   loop_control:
     loop_var: domain_name

roles/matrix-nginx-proxy/tasks/ssl/setup_ssl_self_signed_obtain_for_domain.yml

@@ -6,7 +6,7 @@
     matrix_ssl_certificate_cert_key_path: "{{ matrix_ssl_config_dir_path }}/live/{{ domain_name }}/privkey.pem"
 
 - name: Check if SSL certificate file exists
-  stat:
+  ansible.builtin.stat:
     path: "{{ matrix_ssl_certificate_cert_path }}"
   register: matrix_ssl_certificate_cert_path_stat_result