More ansible-lint fixes
This commit is contained in:
		@@ -2,7 +2,7 @@
 | 
			
		||||
 | 
			
		||||
- ansible.builtin.set_fact:
 | 
			
		||||
    matrix_systemd_services_list: "{{ matrix_systemd_services_list + ['matrix-prometheus-node-exporter.service'] }}"
 | 
			
		||||
  when: matrix_prometheus_node_exporter_enabled|bool
 | 
			
		||||
  when: matrix_prometheus_node_exporter_enabled | bool
 | 
			
		||||
 | 
			
		||||
- block:
 | 
			
		||||
    - name: Fail if matrix-nginx-proxy role already executed
 | 
			
		||||
@@ -12,13 +12,13 @@
 | 
			
		||||
          but it's pointless since the matrix-nginx-proxy role had already executed.
 | 
			
		||||
          To fix this, please change the order of roles in your playbook,
 | 
			
		||||
          so that the matrix-nginx-proxy role would run after the matrix-prometheus-node-exporter role.
 | 
			
		||||
      when: matrix_nginx_proxy_role_executed|default(False)|bool
 | 
			
		||||
      when: matrix_nginx_proxy_role_executed | default(False) | bool
 | 
			
		||||
 | 
			
		||||
    - name: Generate node-exporter metrics proxying configuration for matrix-nginx-proxy (matrix.DOMAIN/metrics/node-exporter)
 | 
			
		||||
      ansible.builtin.set_fact:
 | 
			
		||||
        matrix_prometheus_node_exporter_nginx_metrics_configuration_block: |
 | 
			
		||||
          location /metrics/node-exporter {
 | 
			
		||||
            {% if matrix_nginx_proxy_enabled|default(False) %}
 | 
			
		||||
            {% if matrix_nginx_proxy_enabled | default(False) %}
 | 
			
		||||
              {# Use the embedded DNS resolver in Docker containers to discover the service #}
 | 
			
		||||
              resolver 127.0.0.11 valid=5s;
 | 
			
		||||
              set $backend "matrix-prometheus-node-exporter:9100";
 | 
			
		||||
@@ -34,8 +34,8 @@
 | 
			
		||||
      ansible.builtin.set_fact:
 | 
			
		||||
        matrix_nginx_proxy_proxy_matrix_metrics_additional_system_location_configuration_blocks: |
 | 
			
		||||
          {{
 | 
			
		||||
            matrix_nginx_proxy_proxy_matrix_metrics_additional_system_location_configuration_blocks|default([])
 | 
			
		||||
            matrix_nginx_proxy_proxy_matrix_metrics_additional_system_location_configuration_blocks | default([])
 | 
			
		||||
            +
 | 
			
		||||
            [matrix_prometheus_node_exporter_nginx_metrics_configuration_block]
 | 
			
		||||
          }}
 | 
			
		||||
  when: matrix_prometheus_node_exporter_enabled|bool and matrix_prometheus_node_exporter_metrics_proxying_enabled|bool
 | 
			
		||||
  when: matrix_prometheus_node_exporter_enabled | bool and matrix_prometheus_node_exporter_metrics_proxying_enabled | bool
 | 
			
		||||
 
 | 
			
		||||
@@ -1,10 +1,10 @@
 | 
			
		||||
---
 | 
			
		||||
 | 
			
		||||
- import_tasks: "{{ role_path }}/tasks/init.yml"
 | 
			
		||||
- ansible.builtin.import_tasks: "{{ role_path }}/tasks/init.yml"
 | 
			
		||||
  tags:
 | 
			
		||||
    - always
 | 
			
		||||
 | 
			
		||||
- import_tasks: "{{ role_path }}/tasks/setup.yml"
 | 
			
		||||
- ansible.builtin.import_tasks: "{{ role_path }}/tasks/setup.yml"
 | 
			
		||||
  tags:
 | 
			
		||||
    - setup-all
 | 
			
		||||
    - setup-prometheus-node-exporter
 | 
			
		||||
 
 | 
			
		||||
@@ -10,7 +10,7 @@
 | 
			
		||||
    source: "{{ 'pull' if ansible_version.major > 2 or ansible_version.minor > 7 else omit }}"
 | 
			
		||||
    force_source: "{{ matrix_prometheus_node_exporter_docker_image_force_pull if ansible_version.major > 2 or ansible_version.minor >= 8 else omit }}"
 | 
			
		||||
    force: "{{ omit if ansible_version.major > 2 or ansible_version.minor >= 8 else matrix_prometheus_node_exporter_docker_image_force_pull }}"
 | 
			
		||||
  when: "matrix_prometheus_node_exporter_enabled|bool"
 | 
			
		||||
  when: "matrix_prometheus_node_exporter_enabled | bool"
 | 
			
		||||
  register: result
 | 
			
		||||
  retries: "{{ matrix_container_retries_count }}"
 | 
			
		||||
  delay: "{{ matrix_container_retries_delay }}"
 | 
			
		||||
@@ -22,19 +22,19 @@
 | 
			
		||||
    dest: "{{ matrix_systemd_path }}/matrix-prometheus-node-exporter.service"
 | 
			
		||||
    mode: 0644
 | 
			
		||||
  register: matrix_prometheus_node_exporter_systemd_service_result
 | 
			
		||||
  when: matrix_prometheus_node_exporter_enabled|bool
 | 
			
		||||
  when: matrix_prometheus_node_exporter_enabled | bool
 | 
			
		||||
 | 
			
		||||
- name: Ensure systemd reloaded after matrix-prometheus.service installation
 | 
			
		||||
  ansible.builtin.service:
 | 
			
		||||
    daemon_reload: true
 | 
			
		||||
  when: "matrix_prometheus_node_exporter_enabled|bool and matrix_prometheus_node_exporter_systemd_service_result.changed"
 | 
			
		||||
  when: "matrix_prometheus_node_exporter_enabled | bool and matrix_prometheus_node_exporter_systemd_service_result.changed"
 | 
			
		||||
 | 
			
		||||
#
 | 
			
		||||
# Tasks related to getting rid of matrix-prometheus-node-exporter (if it was previously enabled)
 | 
			
		||||
#
 | 
			
		||||
 | 
			
		||||
- name: Check existence of matrix-prometheus-node-exporter service
 | 
			
		||||
  stat:
 | 
			
		||||
  ansible.builtin.stat:
 | 
			
		||||
    path: "{{ matrix_systemd_path }}/matrix-prometheus-node-exporter.service"
 | 
			
		||||
  register: matrix_prometheus_node_exporter_service_stat
 | 
			
		||||
 | 
			
		||||
@@ -45,15 +45,15 @@
 | 
			
		||||
    enabled: false
 | 
			
		||||
    daemon_reload: true
 | 
			
		||||
  register: stopping_result
 | 
			
		||||
  when: "not matrix_prometheus_node_exporter_enabled|bool and matrix_prometheus_node_exporter_service_stat.stat.exists"
 | 
			
		||||
  when: "not matrix_prometheus_node_exporter_enabled | bool and matrix_prometheus_node_exporter_service_stat.stat.exists"
 | 
			
		||||
 | 
			
		||||
- name: Ensure matrix-prometheus-node-exporter.service doesn't exist
 | 
			
		||||
  ansible.builtin.file:
 | 
			
		||||
    path: "{{ matrix_systemd_path }}/matrix-prometheus-node-exporter.service"
 | 
			
		||||
    state: absent
 | 
			
		||||
  when: "not matrix_prometheus_node_exporter_enabled|bool and matrix_prometheus_node_exporter_service_stat.stat.exists"
 | 
			
		||||
  when: "not matrix_prometheus_node_exporter_enabled | bool and matrix_prometheus_node_exporter_service_stat.stat.exists"
 | 
			
		||||
 | 
			
		||||
- name: Ensure systemd reloaded after matrix-prometheus-node-exporter.service removal
 | 
			
		||||
  ansible.builtin.service:
 | 
			
		||||
    daemon_reload: true
 | 
			
		||||
  when: "not matrix_prometheus_node_exporter_enabled|bool and matrix_prometheus_node_exporter_service_stat.stat.exists"
 | 
			
		||||
  when: "not matrix_prometheus_node_exporter_enabled | bool and matrix_prometheus_node_exporter_service_stat.stat.exists"
 | 
			
		||||
 
 | 
			
		||||
		Reference in New Issue
	
	Block a user