Updates to reviewer comments

This commit is contained in:
Scott Crossen
2020-11-07 17:34:16 -08:00
parent 94dcceb7b9
commit e894befd87
9 changed files with 66 additions and 37 deletions

View File

@ -12,7 +12,7 @@
file:
path: "{{ item.path }}"
state: directory
mode: 0750
mode: 0751
owner: "{{ matrix_user_username }}"
group: "{{ matrix_user_groupname }}"
with_items:

View File

@ -1,10 +1,10 @@
---
- name: Fail if required settings not defined
- name: Fail if required settings not defined in configuration blocks
fail:
msg: >-
You need to define a required configuration setting (`{{ item }}`).
when: "vars[item] == ''"
with_items:
- "matrix_dynamic_dns_domain"
- "matrix_dynamic_dns_provider"
when: "'domain' not in configuration == '' or 'provider' not in configuration == '' or 'protocol' not in configuration == ''"
with_items: "{{ matrix_dynamic_dns_domain_configurations }}"
loop_control:
loop_var: configuration