Commit Graph

14 Commits

Author SHA1 Message Date
Slavi Pantaleev
be5263f397 Move self-building git repository URLs to variables (stop hardcoding) 2020-11-28 21:34:14 +02:00
Slavi Pantaleev
5eed874199 Improve self-building experience (avoid conflict with pullable images)
Fixes https://github.com/spantaleev/matrix-docker-ansible-deploy/issues/716

This patch makes us use more fully-qualified container image names
(either prefixed with docker.io/ or with localhost/).

The latter happens when self-building is enabled.

We've recently had issues where if an image was removed manually
and the service was restarted (making `docker run` fetch it from Docker Hub, etc.),
we'd end up with a pulled image, even though we're aiming for a self-built one.
Re-running the playbook would then not do a rebuild, because:
- the image with that name already exists (even though it's something
else)
- we sometimes had conditional logic where we'd build only if the git
repo changed

By explicitly changing the name of the images (prefixing with localhost/),
we avoid such confusion and the possibility that we'd automatically pul something
which is not what we expect.

Also, I've removed that condition where building would happen on git
changes only. We now always build (unless an image with that name
already exists). We just force-build when the git repo changes.
2020-11-14 23:00:49 +02:00
Slavi Pantaleev
4dbec2470f Fix systemd_path being undefined breakage
Regression since #681 (Github Pull Request).

Fixes #715 (Github Issue).
2020-11-11 00:45:02 +02:00
Slavi Pantaleev
8782919d85 Ensure matrix_dynamic_dns_domain_configurations contains configurations
If `matrix_dynamic_dns_enabled`, we'd like to ensure there's at least
one configuration defined.

Related to #681 (Github Pull Request)
2020-11-10 23:49:36 +02:00
Slavi Pantaleev
97a7c8b0f0 Fix matrix_dynamic_dns_domain_configurations validation check
- `item` was undefined
- `'key' in configurations == ''` was doing the wrong thing

Related to #681 (Github Pull Request)
2020-11-10 23:49:36 +02:00
Scott Crossen
e894befd87 Updates to reviewer comments 2020-11-07 17:53:13 -08:00
Scott Crossen
efeb651789 Removed typo 2020-10-19 11:25:01 -07:00
Scott Crossen
e7d79a95dc removed platform-specific stuff 2020-10-19 10:46:02 -07:00
Scott Crossen
19721be8b1 removed dhcp option 2020-10-18 21:05:32 -07:00
Scott Crossen
de1511b4bb Fixed valdiation 2020-10-16 21:31:07 -07:00
Scott Crossen
806f98447c Removed directory creation 2020-10-16 21:26:58 -07:00
Scott Crossen
51cca4c312 Added containerization 2020-10-16 21:21:58 -07:00
Scott Crossen
53bc7a77e1 fixed EOF issues 2020-10-13 16:47:09 -07:00
Scott Crossen
1f988969a5 Added role for dynamic dns 2020-10-13 16:26:57 -07:00