From 744077f0fda2dc9c41e6f07bb591646b5f5a958e Mon Sep 17 00:00:00 2001
From: transcaffeine <transcaffeine@finally.coffee>
Date: Sat, 29 Mar 2025 21:30:42 +0100
Subject: [PATCH] refactor: use string-backed enum for variant selection

---
 lib/AppConstants.php         | 10 ++++++++++
 lib/Settings/AppSettings.php |  9 +++++++--
 templates/settings.php       | 23 +++++++++--------------
 3 files changed, 26 insertions(+), 16 deletions(-)

diff --git a/lib/AppConstants.php b/lib/AppConstants.php
index e2be724..dbd34d7 100644
--- a/lib/AppConstants.php
+++ b/lib/AppConstants.php
@@ -6,4 +6,14 @@ namespace OCA\PrideFlags;
 
 abstract class AppConstants {
 	public const APP_ID = 'pride_flags';
+	public enum Variants: string {
+		case PRIDE = "Pride";
+		case TRANS = "Trans Pride";
+		case PAN = "Pansexual Pride";
+		case BI = "Bisexual Pride";
+		case ASEXUAL = "Asexual Pride";
+		case LESBIAN = "Lesbian Pride";
+		case NONBINARY = "Non-binary Pride";
+		case NONE = "No customisation";
+	}
 }
diff --git a/lib/Settings/AppSettings.php b/lib/Settings/AppSettings.php
index 158112b..cb1cd6b 100644
--- a/lib/Settings/AppSettings.php
+++ b/lib/Settings/AppSettings.php
@@ -18,11 +18,16 @@ class AppSettings {
 	}
 
 	public function setStringSetting($userId, string $key, string $value): void {
-		$this->config->setUserValue(AppConstants::APP_ID, $userId, $key, $value);
+		// Check for valid Variant here
+		if (AppConstants\Variants::tryFrom($value) != null) {
+			$this->config->setUserValue(AppConstants::APP_ID, $userId, $key, $value);
+		}
 	}
 
 	public function setAppStringSetting(string $key, string $value): void {
-		$this->config->setAppValue(AppConstants::APP_ID, $key, $value);
+		if (AppConstants\Variants::tryFrom($value) != null) {
+			$this->config->setAppValue(AppConstants::APP_ID, $key, $value);
+		}
 	}
 
 	public function getAll($userId): array {
diff --git a/templates/settings.php b/templates/settings.php
index 91529d7..1182d08 100644
--- a/templates/settings.php
+++ b/templates/settings.php
@@ -1,5 +1,8 @@
 <?php
 
+declare(strict_types = 1);
+use OCA\PrideFlags\AppConstants;
+
 ?>
 <div class="pride_flags_user_settings">
 	<div class="settings-section section hidden">
@@ -7,25 +10,17 @@
 		<div class="user-settings folder-flavour" style="margin-left: 40px; display: flex;">
 			<label for="user-settings-folder-flavour-select" style="display: flex; width: 100px;">Folders</label>
 			<select id="user-settings-folder-flavour-select" style="display: flex; width: 200px;">
-				<option value='pride'>Pride</option>
-				<option value='trans'>Trans Pride</option>
-				<option value='pan'>Pansexual Pride</option>
-				<option value='nonbinary'>Non-binary Pride</option>
-				<option value='bi'>Bisexual Pride</option>
-				<option value='asexual'>Asexual Pride</option>
-				<option value='lesbian'>Lesbian Pride</option>
+			<?php foreach (AppConstants\Variants::cases() as $variant): ?>
+				<option value="<?= strtolower($variant->name) ?>"><?= $variant->value ?></option>
+			<?php endforeach ?>
 			</select>
 		</div>
 		<div class="user-settings button-flavour" style="margin-left: 40px; display: flex;">
 			<label for="user-settings-button-flavour-select" style="display: flex; width: 100px;">Buttons</label>
 			<select id="user-settings-button-flavour-select" style="display: flex; width: 200px;">
-				<option value='pride'>Pride</option>
-				<option value='trans'>Trans Pride</option>
-				<option value='pan'>Pansexual Pride</option>
-				<option value='nonbinary'>Non-binary Pride</option>
-				<option value='bi'>Bisexual Pride</option>
-				<option value='asexual'>Asexual Pride</option>
-				<option value='lesbian'>Lesbian Pride</option>
+			<?php foreach (AppConstants\Variants::cases() as $variant): ?>
+				<option value="<?= strtolower($variant->name) ?>"><?= $variant->value ?></option>
+			<?php endforeach ?>
 			</select>
 		</div>
 		<button class="settings-pride-submit button primary" style="margin-left: 40px; display: flex; width: 80px; text-align: center;">Save</button>