fix(nextcloud-fpm-proxy): adapt config to upstream nginx recommendations

roles/nginx_fpm_proxy/templates/nextcloud-nginx.conf.j2

@@ -17,29 +17,79 @@ server {
     listen [::]:80;
     server_name {{ domain | join(' ') }};
 
+    # Path to the root of your installation
+    root /var/www/nextcloud;
+
     # Add headers to serve security related headers
     # Before enabling Strict-Transport-Security headers please read into this
     # topic first.
     add_header Strict-Transport-Security "max-age=15768000; includeSubDomains; preload;" always;
-    #
+
-    # WARNING: Only add the preload option once you read about
+    # Prevent nginx HTTP Server Detection
-    # the consequences in https://hstspreload.org/. This option
+    server_tokens off;
-    # will add the domain to a hardcoded list that is shipped
+
-    # in all major browsers and getting removed from this list
+    # set max upload size
-    # could take several months.
+    client_max_body_size {{ nextcloud_php_upload_limit }};
+    client_body_timeout 300s;
+    fastcgi_buffers 128 4K;
+
+    # Enable gzip but do not remove ETag headers
+    gzip on;
+    gzip_vary on;
+    gzip_comp_level 4;
+    gzip_min_length 256;
+    gzip_proxied expired no-cache no-store private no_last_modified no_etag auth;
+    gzip_types application/atom+xml application/javascript application/json application/ld+json application/manifest+json application/rss+xml application/vnd.geo+json application/vnd.ms-fontobject application/x-font-ttf application/x-web-app-manifest+json application/xhtml+xml application/xml font/opentype image/bmp image/svg+xml image/x-icon text/cache-manifest text/css text/plain text/vcard text/vnd.rim.location.xloc text/vtt text/x-component text/x-cross-domain-policy;
+
+    # Uncomment if your server is build with the ngx_pagespeed module
+    # This module is currently not supported.
+    #pagespeed off;
+
+    # The settings allows you to optimize the HTTP2 bandwidth.
+    # See https://blog.cloudflare.com/delivering-http-2-upload-speed-improvements/
+    # for tuning hints
+    client_body_buffer_size 512k;
+
+    # HTTP response headers borrowed from Nextcloud `.htaccess`
     add_header Referrer-Policy "no-referrer" always;
     add_header X-Content-Type-Options "nosniff" always;
-    add_header X-Download-Options "noopen" always;
     add_header X-Frame-Options "SAMEORIGIN" always;
     add_header X-Permitted-Cross-Domain-Policies "none" always;
-    add_header X-Robots-Tag "none" always;
+    add_header X-Robots-Tag "noindex, nofollow" always;
     add_header X-XSS-Protection "1; mode=block" always;
 
     # Remove X-Powered-By, which is an information leak
     fastcgi_hide_header X-Powered-By;
 
-    # Path to the root of your installation
+    # Set .mjs and .wasm MIME types
-    root /var/www/nextcloud;
+    # Either include it in the default mime.types list
+    # and include that list explicitly or add the file extension
+    # only for Nextcloud like below:
+    include mime.types;
+    types {
+        text/javascript js;
+	application/javascript mjs;
+	application/wasm wasm;
+    }
+
+    # Specify how to handle directories -- specifying `/index.php$request_uri`
+    # here as the fallback means that Nginx always exhibits the desired behaviour
+    # when a client requests a path that corresponds to a directory that exists
+    # on the server. In particular, if that directory contains an index.php file,
+    # that file is correctly served; if it doesn't, then the request is passed to
+    # the front-end controller. This consistent behaviour means that we don't need
+    # to specify custom rules for certain paths (e.g. images and other assets,
+    # `/updater`, `/ocs-provider`), and thus
+    # `try_files $uri $uri/ /index.php$request_uri`
+    # always provides the desired behaviour.
+    index index.php index.html /index.php$request_uri;
+
+    # Rule borrowed from `.htaccess` to handle Microsoft DAV clients
+    location = / {
+        if ( $http_user_agent ~ ^DavClnt ) {
+            return 302 /remote.php/webdav/$is_args$args;
+        }
+    }
 
     location = /robots.txt {
         allow all;
@@ -55,81 +105,55 @@ server {
         # The rules in this block are an adaptation of the rules
         # in `.htaccess` that concern `/.well-known`.
 
-        location = /.well-known/carddav { return 301 https://$host/remote.php/dav/; }
+        location = /.well-known/carddav { return 301 https://$host/remote.php/dav; }
-        location = /.well-known/caldav  { return 301 https://$host/remote.php/dav/; }
+        location = /.well-known/caldav  { return 301 https://$host/remote.php/dav; }
 
-        # The following rule is only needed for the Social app.
+        location = /.well-known/webfinger  { return 301 https://$host/index.php/.well-known/webfinger; }
-        # Uncomment it if you're planning to use this app.
+        location = /.well-known/nodeinfo   { return 301 https://$host/index.php/.well-known/nodeinfo; }
-        location = /.well-known/webfinger	{ return 301 https://$host/public.php?service=webfinger; }
-
-        # The following 2 rules are only needed for the user_webfinger app.
-        # Uncomment it if you're planning to use this app.
-        location = /.well-known/host-meta	{ return 301 https://$host/public.php?service=host-meta; }
-        location = /.well-known/host-meta.json	{ return 301 https://$host/public.php?service=host-meta-json; }
 
         location /.well-known/acme-challenge    { try_files $uri $uri/ =404; }
         location /.well-known/pki-validation    { try_files $uri $uri/ =404; }
 
         # Let Nextcloud's API for `/.well-known` URIs handle all other
         # requests by passing them to the front-end controller.
-        return 301 https://$host/index.php$request_uri;
+        return 301 /index.php$request_uri;
     }
 
-    # set max upload size
+    # Rules borrowed from `.htaccess` to hide certain paths from clients
-    client_max_body_size {{ nextcloud_php_upload_limit }};
+    location ~ ^/(?:build|tests|config|lib|3rdparty|templates|data)(?:$|/)  { return 404; }
-    fastcgi_buffers 128 4K;
+    location ~ ^/(?:\.|autotest|occ|issue|indie|db_|console)                { return 404; }
 
-    # Enable gzip but do not remove ETag headers
+    # Ensure this block, which passes PHP files to the PHP process, is above the blocks
-    gzip on;
+    # which handle static assets (as seen below). If this block is not declared first,
-    gzip_vary on;
+    # then Nginx will encounter an infinite rewriting loop when it prepends `/index.php`
-    gzip_comp_level 4;
+    # to the URI, resulting in a HTTP 500 error response.
-    gzip_min_length 256;
+    location ~ \.php(?:$|/) {
-    gzip_proxied expired no-cache no-store private no_last_modified no_etag auth;
+        # Required for legacy support
-    gzip_types application/atom+xml application/javascript application/json application/ld+json application/manifest+json application/rss+xml application/vnd.geo+json application/vnd.ms-fontobject application/x-font-ttf application/x-web-app-manifest+json application/xhtml+xml application/xml font/opentype image/bmp image/svg+xml image/x-icon text/cache-manifest text/css text/plain text/vcard text/vnd.rim.location.xloc text/vtt text/x-component text/x-cross-domain-policy;
+        rewrite ^/(?!index|remote|public|cron|core\/ajax\/update|status|ocs\/v[12]|updater\/.+|ocs-provider\/.+|.+\/richdocumentscode(_arm64)?\/proxy) /index.php$request_uri;
 
-    # Uncomment if your server is build with the ngx_pagespeed module
+        fastcgi_split_path_info ^(.+?\.php)(/.*)$;
-    # This module is currently not supported.
-    #pagespeed off;
-
-    location / {
-        rewrite ^ /index.php;
-    }
-
-    location ~ ^\/(?:build|tests|config|lib|3rdparty|templates|data)\/ {
-        deny all;
-    }
-    location ~ ^\/(?:\.|autotest|occ|issue|indie|db_|console) {
-        deny all;
-    }
-
-    location ~ ^\/(?:index|remote|public|cron|core\/ajax\/update|status|ocs\/v[12]|updater\/.+|oc[ms]-provider\/.+|.+\/richdocumentscode\/proxy)\.php(?:$|\/) {
-        fastcgi_split_path_info ^(.+?\.php)(\/.*|)$;
         set $path_info $fastcgi_path_info;
+
         try_files $fastcgi_script_name =404;
-        fastcgi_param SCRIPT_FILENAME /var/www/html$fastcgi_script_name;
+
-        fastcgi_param SCRIPT_NAME $fastcgi_script_name;
-        fastcgi_param PATH_INFO $path_info;
-        fastcgi_param HTTPS $https;
-        fastcgi_param HTTP_PROXY "";
-        fastcgi_param REMOTE_ADDR $remote_addr;
-        # Avoid sending the security headers twice
-        fastcgi_param modHeadersAvailable true;
-        # Enable pretty urls
-        fastcgi_param front_controller_active true;
-        fastcgi_pass php-handler;
         include fastcgi_params;
+        fastcgi_param SCRIPT_FILENAME /var/www/html$fastcgi_script_name;
+        fastcgi_param PATH_INFO $path_info;
+        fastcgi_param HTTPS on;
+
+        fastcgi_param modHeadersAvailable true;         # Avoid sending the security headers twice
+        fastcgi_param front_controller_active true;     # Enable pretty urls
+        fastcgi_pass php-handler;
+
         fastcgi_intercept_errors on;
         fastcgi_request_buffering off;
-    }
 
-    location ~ ^\/(?:updater|oc[ms]-provider)(?:$|\/) {
+        fastcgi_max_temp_file_size 0;
-        try_files $uri/ =404;
-        index index.php;
     }
 
     # Adding the cache control header for js, css and map files
     # Make sure it is BELOW the PHP block
-    location ~ \.(?:css|js|woff2?|svg|gif|map)$ {
+    location ~ \.(?:css|js|mjs|svg|gif|png|jpg|ico|wasm|tflite|map|ogg|flac)$ {
         expires 1d;
         # How `sendfile`, `tcp_nopush` and `tcp_nodelay` interact
         # https://thoughts.t37.net/nginx-optimization-understanding-sendfile-tcp-nodelay-and-tcp-nopush-c55cdd276765?gi=f11af534b564
@@ -165,16 +189,19 @@ server {
         access_log off;
     }
 
-    location ~ \.(?:png|html|ttf|ico|jpg|jpeg|bcmap|mp4|webm)$ {
+
-        expires 1d;
+    location ~ \.woff2?$ {
-        sendfile on;
-        tcp_nopush on;
-        tcp_nodelay on;
-        open_file_cache max=10000;
-        open_file_cache_valid 3600s;
-        open_file_cache_errors off;
         try_files $uri /index.php$request_uri;
-        # Optional: Don't log access to other assets
+        expires 7d;         # Cache-Control policy borrowed from `.htaccess`
-        access_log off;
+        access_log off;     # Optional: Don't log access to assets
+    }
+
+    # Rule borrowed from `.htaccess`
+    location /remote {
+        return 301 /remote.php$request_uri;
+    }
+
+    location / {
+        try_files $uri $uri/ /index.php$request_uri;
     }
 }