finallycoffee
/
base
2
0
Fork 1
Code Issues 1 Pull Requests 3 Packages Projects Releases Wiki Activity

feat(roles/lego): Add support for LEGO_HTTP_PORT_FALLBACK #5

Manually merged
jadyn merged 1 commits from jadyn/finallycoffee.base:main into main 2024-08-20 16:01:49 +00:00
Conversation 0 Commits 1 Files Changed 1 +12 -3
jadyn commented 2024-08-01 18:11:15 +00:00
Contributor
Copy Link

ref #4

ref #4
jadyn added 1 commit 2024-08-01 18:11:16 +00:00
transcaffeine requested changes 2024-08-01 19:29:33 +00:00
transcaffeine left a comment
Owner
Copy Link

Commit message scope should not include roles/, should be feat(lego): [...].

Needs some mention/example in lego's README.md

Commit message scope should not include `roles/`, should be `feat(lego): [...]`. Needs some mention/example in [lego's README.md](roles/lego/README.md)
roles/lego/files/lego_run.sh Outdated
@ -3,8 +3,16 @@
LEGO_BINARY=$(/usr/bin/env which lego)
FILES_IN_DIR=$(find "$LEGO_CERT_STORE_PATH/certificates" | wc -l)
transcaffeine commented 2024-08-01 19:24:43 +00:00
Owner
Copy Link

Move L5 directly to before its corresponding if-statement

Move L5 directly to before its corresponding if-statement
jadyn marked this conversation as resolved
roles/lego/files/lego_run.sh Outdated
@ -7,3 +6,1 @@
$LEGO_BINARY $LEGO_COMMAND_ARGS renew --days=$LEGO_CERT_DAYS_TO_RENEW
else
$LEGO_BINARY $LEGO_COMMAND_ARGS run
if [[ -n "$LEGO_HTTP_FALLBACK_PORT" ]]; then
transcaffeine commented 2024-08-01 19:28:04 +00:00
Owner
Copy Link

Where is $LEGO_HTTP_FALLBACK_PORT coming from? possibly missing documentation...

Where is $LEGO_HTTP_FALLBACK_PORT coming from? possibly missing documentation...
roles/lego/files/lego_run.sh Outdated
@ -8,2 +6,2 @@
else
$LEGO_BINARY $LEGO_COMMAND_ARGS run
if [[ -n "$LEGO_HTTP_FALLBACK_PORT" ]]; then
nc -z 127.0.0.1 $LEGO_HTTP_PORT;
transcaffeine commented 2024-08-01 19:27:08 +00:00
Owner
Copy Link

specify -w to avoid waiting for up to 30s. Also consider lego binds to 0.0.0.0, and a webserver might be bound only to an external IP (which would be not detected properly)

specify `-w` to avoid waiting for up to 30s. Also consider lego binds to `0.0.0.0`, and a webserver might be bound only to an external IP (which would be not detected properly)
jadyn commented 2024-08-04 13:11:04 +00:00
Author
Contributor
Copy Link

As the debian/stable version doesn't support IPv6 (yet?) and other options utilizing pre-installed tools require root access, this could be fixed by using a more complex approach or installing additional software. Otherwise I'd suggest looping over all configured (external IPs) using $(hostname --all-ip-addresses).

As the debian/stable version doesn't support IPv6 (yet?) and other options utilizing pre-installed tools require root access, this could be fixed by using a more complex approach or installing additional software. Otherwise I'd suggest looping over all configured (external IPs) using `$(hostname --all-ip-addresses)`.
roles/lego/files/lego_run.sh Outdated
@ -10,1 +10,4 @@
fi
fi
LEGO_COMMAND_ARGS_EXPANDED=$(bash -c "echo $LEGO_COMMAND_ARGS") # This is a bit icky but
echo $LEGO_COMMAND_ARGS_EXPANDED
transcaffeine commented 2024-08-01 19:22:56 +00:00
Owner
Copy Link

Remove debug statement

Remove debug statement
jadyn marked this conversation as resolved
jadyn force-pushed main from d08993d358 to 96f5da9bf6 2024-08-04 13:14:35 +00:00 Compare
jadyn manually merged commit 96f5da9bf6 into main 2024-08-20 16:01:49 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
transcaffeine
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: finallycoffee/base#5
No description provided.
Delete Branch "jadyn/finallycoffee.base:main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?