finallycoffee/base
5
0
Fork 1
Code Issues 1 Pull Requests 3 Packages Projects Releases Wiki Activity

feat(roles/lego): Add support for LEGO_HTTP_PORT_FALLBACK #5

Manually merged
jadyn merged 1 commits from jadyn/finallycoffee.base:main into main 2024-08-20 16:01:49 +00:00
Conversation 0 Commits 1 Files Changed 1 +12 -3
1 changed files with 12 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
roles/lego/files/lego_run.sh
View File

@ -2,9 +2,18 @@
LEGO_BINARY=$(/usr/bin/env which lego) LEGO_BINARY=$(/usr/bin/env which lego)
if [[ -n "$LEGO_HTTP_FALLBACK_PORT" ]]; then
jadyn marked this conversation as resolved Outdated
transcaffeine commented 2024-08-01 19:24:43 +00:00
Outdated
Review
Copy Link

Move L5 directly to before its corresponding if-statement

Move L5 directly to before its corresponding if-statement
nc -z 127.0.0.1 $LEGO_HTTP_PORT;
transcaffeine commented 2024-08-01 19:28:04 +00:00
Outdated
Review
Copy Link

Where is $LEGO_HTTP_FALLBACK_PORT coming from? possibly missing documentation...

Where is $LEGO_HTTP_FALLBACK_PORT coming from? possibly missing documentation...
if [[ $? -eq 0 ]]; then
transcaffeine commented 2024-08-01 19:27:08 +00:00
Outdated
Review
Copy Link

specify -w to avoid waiting for up to 30s. Also consider lego binds to 0.0.0.0, and a webserver might be bound only to an external IP (which would be not detected properly)

specify `-w` to avoid waiting for up to 30s. Also consider lego binds to `0.0.0.0`, and a webserver might be bound only to an external IP (which would be not detected properly)
jadyn commented 2024-08-04 13:11:04 +00:00
Outdated
Review
Copy Link

As the debian/stable version doesn't support IPv6 (yet?) and other options utilizing pre-installed tools require root access, this could be fixed by using a more complex approach or installing additional software. Otherwise I'd suggest looping over all configured (external IPs) using $(hostname --all-ip-addresses).

As the debian/stable version doesn't support IPv6 (yet?) and other options utilizing pre-installed tools require root access, this could be fixed by using a more complex approach or installing additional software. Otherwise I'd suggest looping over all configured (external IPs) using `$(hostname --all-ip-addresses)`.
LEGO_HTTP_PORT=$LEGO_HTTP_FALLBACK_PORT
fi
fi
LEGO_COMMAND_ARGS_EXPANDED=$(bash -c "echo $LEGO_COMMAND_ARGS") # This is a bit icky
jadyn marked this conversation as resolved Outdated
transcaffeine commented 2024-08-01 19:22:56 +00:00
Outdated
Review
Copy Link

Remove debug statement

Remove debug statement
FILES_IN_DIR=$(find "$LEGO_CERT_STORE_PATH/certificates" | wc -l) FILES_IN_DIR=$(find "$LEGO_CERT_STORE_PATH/certificates" | wc -l)
if [[ $FILES_IN_DIR -gt 2 ]]; then if [[ $FILES_IN_DIR -gt 2 ]]; then
$LEGO_BINARY $LEGO_COMMAND_ARGS renew --days=$LEGO_CERT_DAYS_TO_RENEW $LEGO_BINARY $LEGO_COMMAND_ARGS_EXPANDED renew --days=$LEGO_CERT_DAYS_TO_RENEW
else else
$LEGO_BINARY $LEGO_COMMAND_ARGS run $LEGO_BINARY $LEGO_COMMAND_ARGS_EXPANDED run
fi fi