finallycoffee/matrix
finallycoffee/matrix
5
0
Fork 0
Code Issues 5 Pull Requests Actions Packages Projects 1 Releases Wiki Activity

feat(synapse): add deployment method virtualenv #7

Merged
transcaffeine merged 2 commits from transcaffeine/synapse-venv into main 2024-09-28 20:20:09 +00:00
Conversation 0 Commits 2 Files Changed 11 +239 -7
transcaffeine commented 2024-09-27 20:20:27 +00:00
Owner
Copy Link
No description provided.
transcaffeine added 1 commit 2024-09-27 20:20:28 +00:00
transcaffeine force-pushed transcaffeine/synapse-venv from d379c0469d to 609267e099 2024-09-28 09:41:23 +00:00 Compare
transcaffeine force-pushed transcaffeine/synapse-venv from 609267e099 to 50e792cb33 2024-09-28 12:56:43 +00:00 Compare
transcaffeine force-pushed transcaffeine/synapse-venv from 50e792cb33 to 8374b10802 2024-09-28 13:33:43 +00:00 Compare
transcaffeine requested review from leona 2024-09-28 18:54:58 +00:00
leona requested changes 2024-09-28 19:16:05 +00:00
Dismissed
roles/synapse/defaults/main/systemd.yml Outdated
@ -0,0 +1,53 @@
---
synapse_systemd_service_name: "synapse.service"
leona commented 2024-09-28 19:04:26 +00:00
Member
Copy Link

This should either be

synapse_systemd_name

synapse_systemd_enabled

or all variables should be prefixed with synapse_systemd_service

This should either be ``` synapse_systemd_name ``` ``` synapse_systemd_enabled ``` or all variables should be prefixed with `synapse_systemd_service`
transcaffeine commented 2024-09-28 19:56:17 +00:00
Author
Owner
Copy Link

see 8374b10802..015feaf5a6 (diff-e336851dbe45c373ac4021e3f5bd8a0891381371)

see https://git.finally.coffee/finallycoffee/matrix/compare/8374b1080272601f15098fe84827ec12f6a7e0f1..015feaf5a6cc06f93a3e68d951135c950a88efa0#diff-e336851dbe45c373ac4021e3f5bd8a0891381371
transcaffeine marked this conversation as resolved
roles/synapse/tasks/deploy-virtualenv.yml Outdated
@ -0,0 +32,4 @@
ansible.builtin.template:
src: "synapse.service.j2"
dest: "{{ synapse_systemd_service_file }}"
notify:
leona commented 2024-09-28 19:08:18 +00:00
Member
Copy Link

When synapse_state == 'absent' the synapse.service file should be deleted

When `synapse_state == 'absent'` the `synapse.service` file should be deleted
transcaffeine commented 2024-09-28 19:58:52 +00:00
Author
Owner
Copy Link

see 8374b10802..015feaf5a6 (diff-e4c8e7a68b24632db20258e8ef7c6a9f397ddc8e) Line 46 (new)

see https://git.finally.coffee/finallycoffee/matrix/compare/8374b1080272601f15098fe84827ec12f6a7e0f1..015feaf5a6cc06f93a3e68d951135c950a88efa0#diff-e4c8e7a68b24632db20258e8ef7c6a9f397ddc8e Line 46 (new)
transcaffeine marked this conversation as resolved
roles/synapse/tasks/deploy-virtualenv.yml Outdated
@ -0,0 +37,4 @@
- meta: flush_handlers
- name: Ensure systemd service is {{ synapse_state }}
leona commented 2024-09-28 19:11:01 +00:00
Member
Copy Link

Check whether this path/task is required when synapse_state == 'absent'. When this is true the systemd service file will be removed and the systemd daemon will be reloaded. This might lead to systemd auto-stop the unit.

This could reduce complexity

Check whether this path/task is required when `synapse_state == 'absent'`. When this is true the systemd service file will be removed and the systemd daemon will be reloaded. This might lead to systemd auto-stop the unit. This could reduce complexity
transcaffeine marked this conversation as resolved
roles/synapse/templates/synapse.service.j2 Outdated
@ -0,0 +1,44 @@
[Unit]
Description="{{ synapse_systemd_unit_description }}"
leona commented 2024-09-28 19:14:20 +00:00
Member
Copy Link
Description={{ synapse_systemd_unit_description }}
``` Description={{ synapse_systemd_unit_description }} ```
transcaffeine commented 2024-09-28 19:57:05 +00:00
Author
Owner
Copy Link

see 8374b10802..015feaf5a6 (diff-d5a321215b00956942ebd7ef6b229a6e305353e2)

see https://git.finally.coffee/finallycoffee/matrix/compare/8374b1080272601f15098fe84827ec12f6a7e0f1..015feaf5a6cc06f93a3e68d951135c950a88efa0#diff-d5a321215b00956942ebd7ef6b229a6e305353e2
transcaffeine marked this conversation as resolved
transcaffeine force-pushed transcaffeine/synapse-venv from 8374b10802 to 015feaf5a6 2024-09-28 19:55:12 +00:00 Compare
transcaffeine requested review from leona 2024-09-28 19:59:04 +00:00
leona reviewed 2024-09-28 20:10:18 +00:00
roles/synapse/handlers/main.yml Outdated
@ -17,0 +23,4 @@
when:
- synapse_deployment_method == 'virtualenv'
- ansible_facts['service_mgr'] == systemd
- synapse_state == 'started'
leona commented 2024-09-28 20:07:54 +00:00
Member
Copy Link

This should probably be

synapse_systemd_state == 'started'
This should probably be ``` synapse_systemd_state == 'started' ```
transcaffeine commented 2024-09-28 20:13:58 +00:00
Author
Owner
Copy Link

see 015feaf5a6..7d7693a2c7

see https://git.finally.coffee/finallycoffee/matrix/compare/015feaf5a6cc06f93a3e68d951135c950a88efa0..7d7693a2c721056aa728d24a537bfa9441f22b28
transcaffeine marked this conversation as resolved
transcaffeine force-pushed transcaffeine/synapse-venv from 015feaf5a6 to 7d7693a2c7 2024-09-28 20:13:42 +00:00 Compare
leona approved these changes 2024-09-28 20:14:50 +00:00
transcaffeine merged commit 7d7693a2c7 into main 2024-09-28 20:20:09 +00:00
transcaffeine deleted branch transcaffeine/synapse-venv 2024-09-28 20:20:09 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
leona
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: finallycoffee/matrix#7
No description provided.
Delete Branch "transcaffeine/synapse-venv"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?