finallycoffee
/
self-service-api
2
0
Fork 1
Code Issues Pull Requests 1 Projects Releases Wiki Activity

add bcrypt password hashing and clean up code #1

Open
julia wants to merge 5 commits from julia/self-service-api:main into main
pull from: julia/self-service-api:main
merge into: finallycoffee:main
Conversation 0 Commits 5 Files Changed 3 +29 -19
julia commented 2021-06-06 16:54:52 +00:00
First-time contributor
Copy Link

meow ily

meow ily
julia added 2 commits 2021-06-06 16:54:54 +00:00
transcaffeine requested review from Owners 2021-06-06 17:35:54 +00:00
transcaffeine self-assigned this 2021-06-06 17:36:00 +00:00
julia added 1 commit 2021-06-06 17:57:58 +00:00
julia added 1 commit 2021-06-06 18:01:11 +00:00
julia added 1 commit 2021-06-06 18:04:49 +00:00
julia force-pushed main from 92991d63dc to 1786881376 2021-06-06 18:07:24 +00:00 Compare
julia added 1 commit 2021-06-06 18:19:03 +00:00
julia added 1 commit 2021-06-06 18:23:46 +00:00
transcaffeine requested changes 2021-06-16 19:21:26 +00:00
Dockerfile
@ -8,3 +8,3 @@
COPY ./src ./src
CMD ["/usr/local/bin/uvicorn", "src.main:app"]
CMD ["/usr/local/bin/uvicorn", "--host", "::", "--port", "8080", "src.main:app"]
transcaffeine commented 2021-06-16 19:21:03 +00:00
Owner
Copy Link

Ok, so after a lot of testing, it appears that for some reason, uvicorn does not accept :: properly, but starts up anyways (and just does not bind).

Binding to 0.0.0.0 works however, so i suggest using that for now.

Ok, so after a lot of testing, it appears that for some reason, `uvicorn` does not accept `::` properly, but starts up anyways (and just does not bind). Binding to `0.0.0.0` works however, so i suggest using that for now.
This pull request can be merged automatically.
You are not authorized to merge this pull request.
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b julia-main main
git pull main

Step 2:

Merge the changes and update on Gitea.
git checkout main
git merge --no-ff julia-main
git push origin main
Sign in to join this conversation.
Reviewers
No reviewers
transcaffeine
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
transcaffeine
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: finallycoffee/self-service-api#1
No description provided.
Delete Branch "julia/self-service-api:main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?